Document multi-column join conditions in Sync Streams#395
Open
mintlify[bot] wants to merge 3 commits intomainfrom
Open
Document multi-column join conditions in Sync Streams#395mintlify[bot] wants to merge 3 commits intomainfrom
mintlify[bot] wants to merge 3 commits intomainfrom
Conversation
Generated-By: mintlify-agent
simolus3
reviewed
Apr 17, 2026
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
IMO this change is not worth documenting, it fixes an oversight to enable queries that should always have worked.
| SELECT comments.* FROM comments INNER JOIN issues ON comments.issue_id = issues.id | ||
|
|
||
| -- Valid: multiple equality conditions between tables (composite keys) | ||
| SELECT a.* FROM a, b WHERE a.region = b.region AND a.item_id = b.item_id AND b.user_id = auth.user_id() |
Contributor
There was a problem hiding this comment.
Maybe we can find a better example for composite keys though, that might be a good thing to include here.
Collaborator
There was a problem hiding this comment.
Thanks @simolus3 - check below, I added what's hopefully a better example of composite keys
simolus3
approved these changes
Apr 22, 2026
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
Worth noting that the changes haven't been released yet, so we might want to wait for that first. But LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Sync Streams compiler now supports queries that join two tables on multiple columns (composite keys) — previously, these queries would fail with an internal circular reference error.
Triggered by
powersync-ja/powersync-service@824e229 — Support circular references in Sync Streams