Skip to content

Commit 54d46c0

Browse files
committed
More test cleanup, formatting, organization
1 parent 9351d74 commit 54d46c0

4 files changed

Lines changed: 76 additions & 75 deletions

File tree

PowerSync/PowerSync.Common/Client/PowerSyncDatabase.cs

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,12 @@ public interface IPowerSyncDatabase : IEventStream<PowerSyncDBEvent>
6363
Task<NonQueryResult> ExecuteBatch(string query, object?[][]? parameters = null);
6464

6565
Task<T[]> GetAll<T>(string sql, object?[]? parameters = null);
66-
67-
Task<T?> GetOptional<T>(string sql, object?[]? parameters = null);
68-
69-
Task<T> Get<T>(string sql, object?[]? parameters = null);
70-
7166
Task<dynamic[]> GetAll(string sql, object?[]? parameters = null);
7267

68+
Task<T?> GetOptional<T>(string sql, object?[]? parameters = null);
7369
Task<dynamic?> GetOptional(string sql, object?[]? parameters = null);
7470

71+
Task<T> Get<T>(string sql, object?[]? parameters = null);
7572
Task<dynamic> Get(string sql, object?[]? parameters = null);
7673

7774
Task<T> ReadLock<T>(Func<ILockContext, Task<T>> fn, DBLockOptions? options = null);
@@ -474,7 +471,7 @@ public async Task<UploadQueueStats> GetUploadQueueStats(bool includeSize = false
474471
/// </summary>
475472
public async Task<CrudBatch?> GetCrudBatch(int limit = 100)
476473
{
477-
var crudResult = await GetAll<CrudEntryJSON>($"SELECT id, tx_id AS TransactionId, data FROM {PSInternalTable.CRUD} ORDER BY id ASC LIMIT ?", [limit + 1]);
474+
var crudResult = await GetAll<CrudEntryJSON>($"SELECT id, tx_id as transactionId, data FROM {PSInternalTable.CRUD} ORDER BY id ASC LIMIT ?", [limit + 1]);
478475

479476
var all = crudResult.Select(CrudEntry.FromRow).ToList();
480477

@@ -516,7 +513,7 @@ public async Task<UploadQueueStats> GetUploadQueueStats(bool includeSize = false
516513
return await ReadTransaction(async tx =>
517514
{
518515
var first = await tx.GetOptional<CrudEntryJSON>(
519-
$"SELECT id, tx_id AS TransactionId, data FROM {PSInternalTable.CRUD} ORDER BY id ASC LIMIT 1");
516+
$"SELECT id, tx_id AS transactionId, data FROM {PSInternalTable.CRUD} ORDER BY id ASC LIMIT 1");
520517

521518
if (first == null)
522519
{
@@ -534,7 +531,7 @@ public async Task<UploadQueueStats> GetUploadQueueStats(bool includeSize = false
534531
else
535532
{
536533
var result = await tx.GetAll<CrudEntryJSON>(
537-
$"SELECT id, tx_id AS TransactionId, data FROM {PSInternalTable.CRUD} WHERE tx_id = ? ORDER BY id ASC",
534+
$"SELECT id, tx_id as transactionId, data FROM {PSInternalTable.CRUD} WHERE tx_id = ? ORDER BY id ASC",
538535
[txId]);
539536

540537
all = result.Select(CrudEntry.FromRow).ToList();
@@ -596,38 +593,40 @@ public async Task<NonQueryResult> ExecuteBatch(string query, object?[][]? parame
596593
return await Database.ExecuteBatch(query, parameters);
597594
}
598595

599-
public async Task<dynamic[]> GetAll(string query, object?[]? parameters = null)
596+
public async Task<T[]> GetAll<T>(string query, object?[]? parameters = null)
600597
{
601598
await WaitForReady();
602-
return await Database.GetAll(query, parameters);
599+
return await Database.GetAll<T>(query, parameters);
603600
}
604601

605-
public async Task<dynamic?> GetOptional(string query, object?[]? parameters = null)
602+
public async Task<dynamic[]> GetAll(string query, object?[]? parameters = null)
606603
{
607604
await WaitForReady();
608-
return await Database.GetOptional(query, parameters);
605+
return await Database.GetAll(query, parameters);
609606
}
610-
public async Task<dynamic> Get(string query, object?[]? parameters = null)
607+
608+
public async Task<T?> GetOptional<T>(string query, object?[]? parameters = null)
611609
{
612610
await WaitForReady();
613-
return await Database.Get(query, parameters);
611+
return await Database.GetOptional<T>(query, parameters);
614612
}
615613

616-
public async Task<T[]> GetAll<T>(string query, object?[]? parameters = null)
614+
public async Task<dynamic?> GetOptional(string query, object?[]? parameters = null)
617615
{
618616
await WaitForReady();
619-
return await Database.GetAll<T>(query, parameters);
617+
return await Database.GetOptional(query, parameters);
620618
}
621619

622-
public async Task<T?> GetOptional<T>(string query, object?[]? parameters = null)
620+
public async Task<T> Get<T>(string query, object?[]? parameters = null)
623621
{
624622
await WaitForReady();
625-
return await Database.GetOptional<T>(query, parameters);
623+
return await Database.Get<T>(query, parameters);
626624
}
627-
public async Task<T> Get<T>(string query, object?[]? parameters = null)
625+
626+
public async Task<dynamic> Get(string query, object?[]? parameters = null)
628627
{
629628
await WaitForReady();
630-
return await Database.Get<T>(query, parameters);
629+
return await Database.Get(query, parameters);
631630
}
632631

633632
public async Task<T> ReadLock<T>(Func<ILockContext, Task<T>> fn, DBLockOptions? options = null)

PowerSync/PowerSync.Common/MDSQLite/MDSQLiteAdapter.cs

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -154,34 +154,34 @@ public async Task<NonQueryResult> ExecuteBatch(string query, object?[][]? parame
154154
return await WriteTransaction((ctx) => ctx.ExecuteBatch(query, parameters));
155155
}
156156

157-
public async Task<T> Get<T>(string sql, object?[]? parameters = null)
157+
public async Task<T[]> GetAll<T>(string sql, object?[]? parameters = null)
158158
{
159-
return await ReadLock((ctx) => ctx.Get<T>(sql, parameters));
159+
return await ReadLock((ctx) => ctx.GetAll<T>(sql, parameters));
160160
}
161161

162-
public async Task<T[]> GetAll<T>(string sql, object?[]? parameters = null)
162+
public async Task<dynamic[]> GetAll(string sql, object?[]? parameters = null)
163163
{
164-
return await ReadLock((ctx) => ctx.GetAll<T>(sql, parameters));
164+
return await ReadLock((ctx) => ctx.GetAll(sql, parameters));
165165
}
166166

167167
public async Task<T?> GetOptional<T>(string sql, object?[]? parameters = null)
168168
{
169169
return await ReadLock((ctx) => ctx.GetOptional<T>(sql, parameters));
170170
}
171171

172-
public async Task<dynamic> Get(string sql, object?[]? parameters = null)
172+
public async Task<dynamic?> GetOptional(string sql, object?[]? parameters = null)
173173
{
174-
return await ReadLock((ctx) => ctx.Get(sql, parameters));
174+
return await ReadLock((ctx) => ctx.GetOptional(sql, parameters));
175175
}
176176

177-
public async Task<dynamic[]> GetAll(string sql, object?[]? parameters = null)
177+
public async Task<T> Get<T>(string sql, object?[]? parameters = null)
178178
{
179-
return await ReadLock((ctx) => ctx.GetAll(sql, parameters));
179+
return await ReadLock((ctx) => ctx.Get<T>(sql, parameters));
180180
}
181181

182-
public async Task<dynamic?> GetOptional(string sql, object?[]? parameters = null)
182+
public async Task<dynamic> Get(string sql, object?[]? parameters = null)
183183
{
184-
return await ReadLock((ctx) => ctx.GetOptional(sql, parameters));
184+
return await ReadLock((ctx) => ctx.Get(sql, parameters));
185185
}
186186

187187
public async Task<T> ReadTransaction<T>(Func<ITransaction, Task<T>> fn, DBLockOptions? options = null)
@@ -325,33 +325,33 @@ public Task<NonQueryResult> ExecuteBatch(string query, object?[][]? parameters =
325325
return connection.ExecuteBatch(query, parameters);
326326
}
327327

328-
public Task<T> Get<T>(string sql, object?[]? parameters = null)
328+
public Task<T[]> GetAll<T>(string sql, object?[]? parameters = null)
329329
{
330-
return connection.Get<T>(sql, parameters);
330+
return connection.GetAll<T>(sql, parameters);
331331
}
332332

333-
public Task<T[]> GetAll<T>(string sql, object?[]? parameters = null)
333+
public Task<dynamic[]> GetAll(string sql, object?[]? parameters = null)
334334
{
335-
return connection.GetAll<T>(sql, parameters);
335+
return connection.GetAll(sql, parameters);
336336
}
337337

338338
public Task<T?> GetOptional<T>(string sql, object?[]? parameters = null)
339339
{
340340
return connection.GetOptional<T>(sql, parameters);
341341
}
342342

343-
public Task<dynamic> Get(string sql, object?[]? parameters = null)
343+
public Task<dynamic?> GetOptional(string sql, object?[]? parameters = null)
344344
{
345-
return connection.Get(sql, parameters);
345+
return connection.GetOptional(sql, parameters);
346346
}
347347

348-
public Task<dynamic[]> GetAll(string sql, object?[]? parameters = null)
348+
public Task<T> Get<T>(string sql, object?[]? parameters = null)
349349
{
350-
return connection.GetAll(sql, parameters);
350+
return connection.Get<T>(sql, parameters);
351351
}
352352

353-
public Task<dynamic?> GetOptional(string sql, object?[]? parameters = null)
353+
public Task<dynamic> Get(string sql, object?[]? parameters = null)
354354
{
355-
return connection.GetOptional(sql, parameters);
355+
return connection.Get(sql, parameters);
356356
}
357357
}

PowerSync/PowerSync.Common/MDSQLite/MDSQLiteConnection.cs

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -160,28 +160,28 @@ private static List<string> PrepareQueryString(ref string query, int parameterCo
160160
return dynamicParamsList;
161161
}
162162

163-
public async Task<T?> GetOptional<T>(string query, object?[]? parameters = null)
163+
public async Task<T[]> GetAll<T>(string query, object?[]? parameters = null)
164164
{
165165
DynamicParameters? dynamicParams = PrepareQuery(ref query, parameters);
166-
return dynamicParams == null
167-
? await Db.QueryFirstOrDefaultAsync<T>(query, commandType: CommandType.Text)
168-
: await Db.QueryFirstOrDefaultAsync<T>(query, dynamicParams, commandType: CommandType.Text);
166+
return [..dynamicParams == null
167+
? await Db.QueryAsync<T>(query, commandType: CommandType.Text)
168+
: await Db.QueryAsync<T>(query, dynamicParams, commandType: CommandType.Text)];
169169
}
170170

171-
public async Task<T> Get<T>(string query, object?[]? parameters = null)
171+
public async Task<dynamic[]> GetAll(string query, object?[]? parameters = null)
172172
{
173173
DynamicParameters? dynamicParams = PrepareQuery(ref query, parameters);
174-
return dynamicParams == null
175-
? await Db.QueryFirstAsync<T>(query, commandType: CommandType.Text)
176-
: await Db.QueryFirstAsync<T>(query, dynamicParams, commandType: CommandType.Text);
174+
return [..dynamicParams == null
175+
? await Db.QueryAsync(query, commandType: CommandType.Text)
176+
: await Db.QueryAsync(query, dynamicParams, commandType: CommandType.Text)];
177177
}
178178

179-
public async Task<T[]> GetAll<T>(string query, object?[]? parameters = null)
179+
public async Task<T?> GetOptional<T>(string query, object?[]? parameters = null)
180180
{
181181
DynamicParameters? dynamicParams = PrepareQuery(ref query, parameters);
182-
return [..dynamicParams == null
183-
? await Db.QueryAsync<T>(query, commandType: CommandType.Text)
184-
: await Db.QueryAsync<T>(query, dynamicParams, commandType: CommandType.Text)];
182+
return dynamicParams == null
183+
? await Db.QueryFirstOrDefaultAsync<T>(query, commandType: CommandType.Text)
184+
: await Db.QueryFirstOrDefaultAsync<T>(query, dynamicParams, commandType: CommandType.Text);
185185
}
186186

187187
public async Task<dynamic?> GetOptional(string query, object?[]? parameters = null)
@@ -192,20 +192,20 @@ public async Task<T[]> GetAll<T>(string query, object?[]? parameters = null)
192192
: await Db.QueryFirstOrDefaultAsync(query, dynamicParams, commandType: CommandType.Text);
193193
}
194194

195-
public async Task<dynamic> Get(string query, object?[]? parameters = null)
195+
public async Task<T> Get<T>(string query, object?[]? parameters = null)
196196
{
197197
DynamicParameters? dynamicParams = PrepareQuery(ref query, parameters);
198198
return dynamicParams == null
199-
? await Db.QueryFirstAsync(query, commandType: CommandType.Text)
200-
: await Db.QueryFirstAsync(query, dynamicParams, commandType: CommandType.Text);
199+
? await Db.QueryFirstAsync<T>(query, commandType: CommandType.Text)
200+
: await Db.QueryFirstAsync<T>(query, dynamicParams, commandType: CommandType.Text);
201201
}
202202

203-
public async Task<dynamic[]> GetAll(string query, object?[]? parameters = null)
203+
public async Task<dynamic> Get(string query, object?[]? parameters = null)
204204
{
205205
DynamicParameters? dynamicParams = PrepareQuery(ref query, parameters);
206-
return [..dynamicParams == null
207-
? await Db.QueryAsync(query, commandType: CommandType.Text)
208-
: await Db.QueryAsync(query, dynamicParams, commandType: CommandType.Text)];
206+
return dynamicParams == null
207+
? await Db.QueryFirstAsync(query, commandType: CommandType.Text)
208+
: await Db.QueryFirstAsync(query, dynamicParams, commandType: CommandType.Text);
209209
}
210210

211211
public async Task<NonQueryResult> Execute(string query, object?[]? parameters = null)

0 commit comments

Comments
 (0)