Skip to content

Reduce warnings on dotnet build #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucDeCaf merged 1 commit into from
Apr 23, 2026
Merged

Reduce warnings on dotnet build #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PowerSync/PowerSync.Common/Client/PowerSyncDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ public async Task<UploadQueueStats> GetUploadQueueStats(bool includeSize = false
///
/// Use this from the <see cref="IPowerSyncBackendConnector.UploadData"/> callback.
/// <para />
/// Once the data have been successfully uploaded, call <see cref="CrudTransaction.Complete"/> before
/// Once the data have been successfully uploaded, call <see cref="CrudBatch.Complete"/> before
/// requesting the next transaction.
/// <para />
/// Unlike <see cref="GetCrudBatch"/>, this only returns data from a single transaction at a time.
Expand Down
7 changes: 4 additions & 3 deletions PowerSync/PowerSync.Common/DB/Schema/Attributes/AttributeParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ public AttributeParser(Type type)
{
_type = type;

_tableAttr = _type.GetCustomAttribute<TableAttribute>();
if (_tableAttr == null)
var tableAttr = _type.GetCustomAttribute<TableAttribute>();
if (tableAttr == null)
{
throw new InvalidOperationException("Table classes must be marked with TableAttribute.");
}
_tableAttr = tableAttr;
}

public Table ParseTable()
Expand Down Expand Up @@ -194,7 +195,7 @@ public CustomPropertyTypeMap ParseDapperTypeMap()
(type, columnName) => type.GetProperties()
.FirstOrDefault(prop => prop.GetCustomAttributes()
.OfType<ColumnAttribute>()
.Any(columnAttr => columnAttr.Name == columnName))
.Any(columnAttr => columnAttr.Name == columnName))!
);
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/PowerSync/PowerSync.Common.IntegrationTests/PowerSync.Common.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0</TargetFrameworks>
<LangVersion>12</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion Tests/PowerSync/PowerSync.Common.PerformanceTests/PowerSync.Common.PerformanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0;net8.0;net9.0</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0;net9.0</TargetFrameworks>
<LangVersion>12</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion Tests/PowerSync/PowerSync.Common.Tests/PowerSync.Common.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0;net8.0;net9.0</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0;net9.0</TargetFrameworks>
<LangVersion>12</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
Expand Down
7 changes: 2 additions & 5 deletions demos/WPF/ViewModels/MainWindowViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@ public MainWindowViewModel(PowerSyncDatabase db)
// Set up the listener to track the status changes
_ = Task.Run(async () =>
{
await foreach (var update in _db.ListenAsync(new CancellationToken()))
await foreach (var update in _db.Events.OnStatusChanged.ListenAsync(new CancellationToken()))
{
if (update.StatusChanged != null)
{
Connected = update.StatusChanged.Connected;
}
Connected = update.Status.Connected;
}
});
}
Expand Down