Remove legacy sync client

Author: simolus3

packages/node/tests/sync_protocol.ts packages/common/legacy/sync_protocol.d.tspackages/node/tests/sync_protocol.ts renamed to packages/common/legacy/sync_protocol.d.ts

@@ -30,14 +30,18 @@
         "types": "./dist/index.d.cts",
         "require": "./dist/bundle.cjs"
       }
+    },
+    "./sync_protocol": {
+      "types": "./legacy/sync_protocol.d.ts"
     }
   },
   "author": "PowerSync",
   "license": "Apache-2.0",
   "files": [
     "lib",
     "dist",
-    "src"
+    "src",
+    "legacy"
   ],
   "repository": {
     "type": "git",
@@ -64,7 +68,6 @@
     "@rollup/plugin-node-resolve": "catalog:",
     "@types/node": "catalog:",
     "@types/uuid": "catalog:",
-    "bson": "catalog:",
     "buffer": "^6.0.3",
     "cross-fetch": "^4.1.0",
     "estree-walker": "^3.0.3",

packages/common/package.json

@@ -37,7 +37,7 @@ function defineBuild(isNode) {
       }
     ],
     plugins,
-    external: ['bson', isNode ? 'event-iterator' : undefined]
+    external: [isNode ? 'event-iterator' : undefined]
   };
 }
 

packages/common/rollup.config.mjs

@@ -1,4 +1,3 @@
-import type { BSON } from 'bson';
 import { type fetch } from 'cross-fetch';
 import Logger, { ILogger } from 'js-logger';
 import { Requestable, RSocket, RSocketConnector } from 'rsocket-core';
@@ -15,8 +14,6 @@ import {
 import { EventIterator } from 'event-iterator';
 import type { Queue } from 'event-iterator/lib/event-iterator.js';
 
-export type BSONImplementation = typeof BSON;
-
 export type RemoteConnector = {
   fetchCredentials: () => Promise<PowerSyncCredentials | null>;
   invalidateCredentials?: () => void;
@@ -264,11 +261,6 @@ export abstract class AbstractRemote {
     return res.json();
   }
 
-  /**
-   * Provides a BSON implementation. The import nature of this varies depending on the platform
-   */
-  abstract getBSON(): Promise<BSONImplementation>;
-
   /**
    * @returns A text decoder decoding UTF-8. This is a method to allow patching it for Hermes which doesn't support the
    * builtin, without forcing us to bundle a polyfill with `@powersync/common`.
@@ -285,26 +277,13 @@ export abstract class AbstractRemote {
    * Returns a data stream of sync line data, fetched via RSocket-over-WebSocket.
    *
    * The only mechanism to abort the returned stream is to use the abort signal in {@link SocketSyncStreamOptions}.
-   *
-   * @param bson A BSON encoder and decoder. When set, the data stream will be requested with a BSON payload
-   * (required for compatibility with older sync services).
    */
-  async socketStreamRaw(
-    options: SocketSyncStreamOptions,
-    bson?: typeof BSON
-  ): Promise<SimpleAsyncIterator<Uint8Array>> {
+  async socketStreamRaw(options: SocketSyncStreamOptions): Promise<SimpleAsyncIterator<Uint8Array>> {
     const { path, fetchStrategy = FetchStrategy.Buffered } = options;
-    const mimeType = bson == null ? 'application/json' : 'application/bson';
+    const mimeType = 'application/json';
 
     function toBuffer(js: any): Buffer {
-      let contents: any;
-      if (bson != null) {
-        contents = bson.serialize(js);
-      } else {
-        contents = JSON.stringify(js);
-      }
-
-      return Buffer.from(contents);
+      return Buffer.from(JSON.stringify(js));
     }
 
     const syncQueueRequestSize = fetchStrategy == FetchStrategy.Buffered ? 10 : 1;

packages/common/src/client/sync/stream/AbstractRemote.ts

@@ -9,7 +9,6 @@ import { CrudEntry } from '../bucket/CrudEntry.js';
 import { AbstractRemote, FetchStrategy, SyncStreamOptions } from './AbstractRemote.js';
 import { EstablishSyncStream, Instruction, coreStatusToJs } from './core-instruction.js';
 import { injectable, InjectableIterator, map, SimpleAsyncIterator } from '../../../utils/stream_transform.js';
-import type { BSON } from 'bson';
 import { StreamingSyncRequestParameterType } from './JsonValue.js';
 
 export enum LockType {
@@ -639,21 +638,17 @@ The next upload iteration will be delayed.`);
   private async receiveSyncLines(data: {
     options: SyncStreamOptions;
     connection: RequiredPowerSyncConnectionOptions;
-    bson?: typeof BSON;
   }): Promise<SimpleAsyncIterator<Uint8Array | string>> {
-    const { options, connection, bson } = data;
+    const { options, connection } = data;
     const remote = this.options.remote;
 
     if (connection.connectionMethod == SyncStreamConnectionMethod.HTTP) {
       return await remote.fetchStream(options);
     } else {
-      return await this.options.remote.socketStreamRaw(
-        {
-          ...options,
-          ...{ fetchStrategy: connection.fetchStrategy }
-        },
-        bson
-      );
+      return await this.options.remote.socketStreamRaw({
+        ...options,
+        ...{ fetchStrategy: connection.fetchStrategy }
+      });
     }
   }
 

packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts

@@ -67,14 +67,14 @@
   },
   "dependencies": {
     "@powersync/common": "workspace:*",
-    "bson": "catalog:",
     "comlink": "catalog:",
     "undici": "^7.11.0"
   },
   "devDependencies": {
     "@powersync/drizzle-driver": "workspace:*",
     "@types/node": "catalog:",
     "better-sqlite3": "^12.2.0",
+    "bson": "catalog:",
     "drizzle-orm": "catalog:",
     "js-logger": "catalog:",
     "rollup": "catalog:",

packages/node/package.json

@@ -4,21 +4,12 @@ import {
   type ILogger,
   AbstractRemote,
   AbstractRemoteOptions,
-  BSONImplementation,
   DEFAULT_REMOTE_LOGGER,
   FetchImplementation,
   FetchImplementationProvider,
   RemoteConnector
 } from '@powersync/common';
-import { BSON } from 'bson';
-import {
-  Dispatcher,
-  EnvHttpProxyAgent,
-  ErrorEvent,
-  getGlobalDispatcher,
-  ProxyAgent,
-  WebSocket as UndiciWebSocket
-} from 'undici';
+import { Dispatcher, EnvHttpProxyAgent, getGlobalDispatcher, ProxyAgent, WebSocket as UndiciWebSocket } from 'undici';
 
 export const STREAMING_POST_TIMEOUT_MS = 30_000;
 
@@ -98,10 +89,6 @@ export class NodeRemote extends AbstractRemote {
       `${os.platform()}/${os.release()}`
     ].join(' ');
   }
-
-  async getBSON(): Promise<BSONImplementation> {
-    return BSON;
-  }
 }
 
 function defaultFetchDispatcher(): Dispatcher {

packages/node/src/sync/stream/NodeRemote.ts

@@ -19,7 +19,7 @@ import {
   TestConnector,
   waitForSyncStatus
 } from './utils';
-import { BucketChecksum, OplogEntryJSON } from './sync_protocol';
+import { BucketChecksum, OplogEntryJSON } from '@powersync/common/sync_protocol';
 
 describe('Sync', () => {
   describe('json', () => defineSyncTests(false));

packages/node/tests/sync.test.ts

@@ -4,6 +4,7 @@ import path from 'node:path';
 import { ReadableStream, TransformStream } from 'node:stream/web';
 
 import { createLogger } from '@powersync/common';
+import { BucketChecksum, StreamingSyncCheckpoint, StreamingSyncLine } from '@powersync/common/sync_protocol';
 import Logger from 'js-logger';
 import { onTestFinished, test } from 'vitest';
 import {
@@ -18,7 +19,6 @@ import {
   column
 } from '../lib';
 import { BSON } from 'bson';
-import { BucketChecksum, StreamingSyncCheckpoint, StreamingSyncLine } from './sync_protocol';
 
 export async function createTempDir() {
   const ostmpdir = os.tmpdir();

packages/node/tests/utils.ts

@@ -81,6 +81,7 @@
     "@powersync/kysely-driver": "workspace:*",
     "@powersync/vue": "workspace:*",
     "@powersync/web": "workspace:*",
+    "@powersync/common": "workspace:*",
     "bson": "catalog:",
     "comlink": "catalog:",
     "nuxt": "^4.3.1",