AI feedback

Author: simolus3

packages/common/src/client/sync/stream/AbstractRemote.ts

@@ -523,13 +523,13 @@ export abstract class AbstractRemote {
      *  Aborting the active fetch request while it is being consumed seems to throw
      *  an unhandled exception on the window level.
      */
-    if (abortSignal?.aborted) {
+    if (abortSignal.aborted) {
       throw new AbortOperation('Abort request received before making fetchStreamRaw request');
     }
 
     const controller = new AbortController();
     let reader: ReadableStreamDefaultReader<Uint8Array> | null = null;
-    abortSignal?.addEventListener('abort', () => {
+    abortSignal.addEventListener('abort', () => {
       const reason =
         abortSignal.reason ??
         new AbortOperation('Cancelling network request before it resolves. Abort signal has been received.');

packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts

@@ -689,7 +689,7 @@ The next upload iteration will be delayed.`);
     });
   }
 
-  async receiveSyncLines(data: {
+  private async receiveSyncLines(data: {
     options: SyncStreamOptions;
     connection: RequiredPowerSyncConnectionOptions;
     bson?: typeof BSON;

packages/common/src/utils/stream_transform.ts

@@ -31,7 +31,7 @@ export function map<T1, T2>(source: SimpleAsyncIterator<T1>, map: (source: T1) =
 }
 
 export interface InjectableIterator<T> extends SimpleAsyncIterator<T> {
-  inject(event: T);
+  inject(event: T): void;
 }
 
 /**
@@ -84,7 +84,7 @@ export function injectable<T>(source: SimpleAsyncIterator<T>): InjectableIterato
   return {
     next: () => {
       return new Promise((resolve, reject) => {
-        // First priority: Dispatch from upstream
+        // First priority: Dispatch ready upstream events.
         if (sourceIsDone) {
           return resolve(doneResult);
         }
@@ -155,8 +155,8 @@ export function extractJsonLines(
         buffer += data;
 
         const lines = buffer.split('\n');
-        for (var i = 0; i < lines.length - 1; i++) {
-          var l = lines[i].trim();
+        for (let i = 0; i < lines.length - 1; i++) {
+          const l = lines[i].trim();
           if (l.length > 0) {
             pendingLines.push(l);
           }

packages/common/tests/utils/stream_transform.test.ts

@@ -40,7 +40,7 @@ describe('extractJsonLines', () => {
   });
 });
 
-describe('injectible', () => {
+describe('injectable', () => {
   test('forwards upstream events', async () => {
     async function* source() {
       yield 1;