Make connection type required

Author: simolus3

packages/adapter-sql-js/src/SQLJSAdapter.ts

@@ -173,8 +173,8 @@ class SqlJsLockContext extends LockContext {
     super();
   }
 
-  get connectionType() {
-    return undefined;
+  get connectionType(): 'readWrite' {
+    return 'readWrite';
   }
 
   async executeRaw(query: string, params?: any[]): Promise<RawQueryResult> {

packages/capacitor/src/adapter/CapacitorSQLiteAdapter.ts

@@ -248,8 +248,8 @@ export class CapacitorSQLiteAdapter extends DBAdapter {
     };
 
     class CapacitorLockContext extends LockContext {
-      get connectionType() {
-        return undefined;
+      get connectionType(): 'readWrite' {
+        return 'readWrite';
       }
 
       getAll<T>(sql: string, parameters?: any[]): Promise<T[]> {

packages/common/src/db/DBAdapter.ts

@@ -90,12 +90,12 @@ export abstract class LockContext implements SqlExecutor, DBGetUtils {
   /**
    * How the connection has been opened.
    *
-   * `writer` indicates that the lock context is capable of writing to the database.
+   * `readWrite` indicates that the lock context is capable of writing to the database.
    * `queryOnly` indicates that the lock context has been opened in a readwrite mode, but a `PRAGMA query_only = TRUE`
    * disabled writes.
    * `readOnly` indicates that the lock context has been opened by passing `SQLITE_OPEN_READONLY` to `sqlite3_open_v2`.
    */
-  abstract get connectionType(): 'writer' | 'queryOnly' | 'readOnly' | undefined;
+  abstract get connectionType(): 'readWrite' | 'queryOnly' | 'readOnly';
 
   abstract executeRaw<T>(query: string, params?: any[] | undefined): Promise<RawQueryResult>;
 

packages/node/src/db/RemoteConnection.ts

@@ -31,7 +31,7 @@ export class RemoteConnection extends LockContext {
   }
 
   public get connectionType() {
-    return this.readonly ? 'readOnly' : 'writer';
+    return this.readonly ? 'readOnly' : 'readWrite';
   }
 
   /**

packages/powersync-op-sqlite/src/db/OPSQLiteConnection.ts

@@ -42,7 +42,7 @@ export class OPSQLiteConnection extends LockContext {
   }
 
   get connectionType() {
-    return this.options.readonly ? 'queryOnly' : 'writer';
+    return this.options.readonly ? 'queryOnly' : 'readWrite';
   }
 
   addTableUpdate(update: OPSQLiteUpdateNotification) {

packages/react-native/src/db/adapters/react-native-quick-sqlite/RNQSDBAdapter.ts

@@ -66,8 +66,8 @@ class QuickSqliteContext extends LockContext {
     super();
   }
 
-  get connectionType() {
-    return undefined;
+  get connectionType(): 'readWrite' {
+    return 'readWrite';
   }
 
   async execute<T>(query: string, params?: any[]): Promise<QueryResult<T>> {

packages/tauri/guest-js/pool.ts

@@ -53,7 +53,7 @@ export class RustDatabaseAdapter extends DBAdapter {
     const handle = (connection as any).CreatedHandle as number;
 
     try {
-      return await fn(new RustLockContext(handle));
+      return await fn(new RustLockContext(handle, write ? 'readWrite' : 'readOnly'));
     } finally {
       await await powersyncCommand({ CloseHandle: handle });
     }
@@ -65,14 +65,13 @@ export class RustDatabaseAdapter extends DBAdapter {
 }
 
 class RustLockContext extends LockContext {
-  constructor(readonly handle: number) {
+  constructor(
+    readonly handle: number,
+    readonly connectionType: 'readWrite' | 'readOnly'
+  ) {
     super();
   }
 
-  get connectionType(): undefined {
-    return undefined;
-  }
-
   private async executeInner(query: string, params: any[]) {
     const result = await powersyncCommand({
       ExecuteSql: {

packages/web/src/db/adapters/SSRDBAdapter.ts

@@ -38,8 +38,8 @@ export class SSRDBAdapter extends DBAdapter {
 }
 
 class StubLockContext extends LockContext {
-  get connectionType() {
-    return undefined;
+  get connectionType(): 'readWrite' {
+    return 'readWrite';
   }
 
   async executeRaw(): Promise<RawQueryResult> {

packages/web/src/db/adapters/wa-sqlite/DatabaseClient.ts

@@ -194,8 +194,8 @@ class ClientLockContext extends LockContext {
     this.#token = token;
   }
 
-  get connectionType() {
-    return undefined;
+  get connectionType(): 'readWrite' {
+    return 'readWrite';
   }
 
   /**