feat: Logging cleanup in packages (web, node, attachments, react, vue)#565
Merged
Conversation
… and sync worker.
…ve controlled logging in packages like Attachments, React, and Vue.
🦋 Changeset detectedLatest commit: 0857d51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chriztiaan
changed the title
Chriztiaan
changed the title
simolus3
approved these changes
Apr 23, 2025
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
Probably best to let Steven take another look too, but these changes look good to me.
stevensJourney
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of 3 planned PRs for logging cleanup.
This PR sweeps some of our logging across multiple packages which either didn't respect log levels or were using
console.xxx()to log information. The most noteworthy changes were inBroadcastLogger.ts.For the
attachments,vue, andreactpackages the easiest way to access the logger instance was to expose it on the PowerSync database instance.