feat: Detox simulator test runner#590
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c38064c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
I left some minor comments. Overall this is pretty cool.
Android tests should be possible as discussed offline.
… from root config.
…s into op-sqlite-tests
stevensJourney
previously approved these changes
May 27, 2025
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
Happy with these changes from my side.
stevensJourney
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions
This PR introduces an OP-SQLITE adapter test suite that works in a similar way to RNQS. This project's setup differs quite a bit though as it is Detox based, but still runs tests against a simulator. At the moment only the iOS simulator is being used.
The tests are pulled into a single Detox test, an interaction in the UI kicks off all the tests and we pull the state of each test out of the UI which then gets reported - any failures will cause the single Detox test to fail.
Considerations
I am not sure whether this and future simulator/emulator Github actions should run on
PRas they do take a bit longer than our other actions, it's good to have them regardless. They also seem to be nondeterministically unstable.Future work