poc: Expo Fetch#591
Closed
stevensJourney wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: 111a306 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
Closing this since the root issue was resolved in #595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We currently use
react-native-fetch-apiin the React Native SDK to performfetchoperations. This is required since the standard React Nativefetchimplementation does not support HTTP text streaming.Some users recently reported errors of the form
Which most likely is caused by
react-native-fetch-api.Expo 52 introduced their own implementation for
fetchwhich supports HTTP streaming.This PR attempts to require and use Expo's fetch implementation (if available) - we default to
react-native-fetch-apiif Expo >= 52 is not installed.