Rust: Trigger CRUD upload on connect#650
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6c35bcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
commented
Jun 30, 2025
simolus3
force-pushed
the
rust-upload-local-writes
branch
from
b0dcbfc to
da6f7d5
Compare
simolus3
force-pushed
the
rust-upload-local-writes
branch
from
9265002 to
6c35bcc
Compare
stevensJourney
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This triggers a CRUD upload when receiving the first sync line to ensure that local writes made while offline have a chance to get uploaded.
This also refactors
DataStreamto allow adding data while it's blocked onlowWater- this is used by the Rust sync client because we might have to wait for lines from upstream and also have a upload completion notification that needs to be added to the stream.Finally, I've moved some of the sync tests from the
webpackage tonode. This ensures they're tested both with the JS and the Rust implementation. And while it shouldn't make a difference, node tests appear to be less flaky (and certainly a bit easier to debug).