Fix: Rust Client Disconnect Race#700
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2f6153c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
whygee-dev
pushed a commit
to whygee-dev/powersync-js
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When disconnecting and connecting frequently, it is currently possible for the Rust sync clients to get locked in a frozen state if the
StreamingSyncClientis disconnected/aborted before it has connected.This can happen if:
StreamingSyncImplementation'sAbortControlleris marked as aborted, but we nest theAbortControllerhere.AbortSignalhas been aborted before making the request (and we throw), but due to the wrapped controller used in the Rust implementation we don't detect that the wrapped controller has been aborted. The wrapped controller will also never be aborted since the upstream controller won't emit theabortedevent again (since it was aborted before)ConnectionManager'sdisconnectingPromisenever resolves, which causes a shared sync implementation to be frozen.This checks the upstream AbortSignal before wrapping it. The abort is propagated by throwing a
AbortOperation.This could also have happened with the HTTP connection method. A check has been added there also.