fix: useQuery() not reacting to query/param changes in StrictMode#703
Merged
Conversation
…ution when the query or parameters changed while using StrictMode.
🦋 Changeset detectedLatest commit: 5036ff3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
previously approved these changes
Sep 2, 2025
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
The implementation and test changes look good to me 👍
simolus3
approved these changes
Sep 2, 2025
stevensJourney
approved these changes
Sep 3, 2025
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
Looks good to me :)
whygee-dev
pushed a commit
to whygee-dev/powersync-js
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useWatchedQuery's useEffect responsible for updating the watchedQuery's settings on query change never triggered in React.StrictMode.Basically the
queryChangedprop changes fromfalse=>true=>falsebefore the useEffect would pick up the change. So that "query change" event was consumed without doing anything, I have introduced a ref approach to protect against this from happening.For good measure I have opted to change the
useQuerytest suite to run the tests in both normal and Strict mode, if we like this pattern we can apply it to the other React package's tests.