Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/grumpy-monkeys-laugh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/web': patch
---

Remove deprecated `unload` listener.
10 changes: 1 addition & 9 deletions packages/web/src/db/PowerSyncDatabase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import { AsyncDbAdapter } from './adapters/AsyncWebAdapter.js';

export interface WebPowerSyncFlags extends WebSQLFlags {
/**
* @deprecated This flag is no longer used. Navigator locks now handle tab detection automatically.
* Externally unload open PowerSync database instances when the window closes.
* Setting this to `true` requires calling `close` on all open PowerSyncDatabase
* instances before the window unloads
Expand Down Expand Up @@ -127,7 +128,6 @@ function assertValidDatabaseOptions(options: WebPowerSyncDatabaseOptions): void
export class PowerSyncDatabase extends AbstractPowerSyncDatabase {
static SHARED_MUTEX = new Mutex();

protected unloadListener?: () => Promise<void>;
protected resolvedFlags: WebPowerSyncFlags;

constructor(options: WebPowerSyncDatabaseOptionsWithAdapter);
Expand All @@ -140,11 +140,6 @@ export class PowerSyncDatabase extends AbstractPowerSyncDatabase {
assertValidDatabaseOptions(options);

this.resolvedFlags = resolveWebPowerSyncFlags(options.flags);

if (this.resolvedFlags.enableMultiTabs && !this.resolvedFlags.externallyUnload) {
this.unloadListener = () => this.close({ disconnect: false });
window.addEventListener('unload', this.unloadListener);
}
}

async _initialize(): Promise<void> {
Expand Down Expand Up @@ -190,9 +185,6 @@ export class PowerSyncDatabase extends AbstractPowerSyncDatabase {
* multiple tabs are not enabled.
*/
close(options?: PowerSyncCloseOptions): Promise<void> {
if (this.unloadListener) {
window.removeEventListener('unload', this.unloadListener);
}
return super.close({
// Don't disconnect by default if multiple tabs are enabled
disconnect: options?.disconnect ?? !this.resolvedFlags.enableMultiTabs
Expand Down