Remove JavaScript sync client#938
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7e12be0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
previously approved these changes
May 4, 2026
stevensJourney
left a comment
stevensJourney
left a comment
Collaborator
There was a problem hiding this comment.
Happy with these changes :)
stevensJourney
approved these changes
May 4, 2026
benitav
added
the
Product Visibility
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the JavaScript client implementation, leaving the existing default (Rust) as the only option. That removes about 2k lines we no longer have to maintain, and should slightly decrease the bundle size for our users.
The changes to
AbstractStreamingSyncImplementation.tsshould be uncontroversial, they just involve deleting the old client. The rest of this PRs applies simplifications to build scripts and reduces our dependency footprint. That deserves some explanations:@powersync/common, I've removed TypeScript definitions for sync protocol lines and bucket storage methods used to implement the old sync client. We still want to be able to use those types in tests though. So I've added a types-only export to@powersync/commonfor that purpose.bsondependency from our SDKs. There's nothing really wrong with that package anymore (as in, it doesn't require top-level async or polyfills since version 6), but it's evectively unused and fewer dependencies are always better. The only remaining place involving BSON was to encode the sync request body for RSocket. Old versions (1.11.3 and older) of the PowerSync service didn't accept JSON payloads there, so this drops compatibility with them. Due to an oversight on my part, the Rust client never passed a BSON encoder to that method though. So adding the Rust client implicitly dropped support for those old versions, and I'm not aware of any complaints since we've made it the default. At this point, I think the simplification of not having the BSON dependency around anymore outweighs backwards-compatibility.