Fix readTransaction errors on node and op-sqlite drivers#941
Merged
Conversation
🦋 Changeset detectedLatest commit: 12c4def The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
approved these changes
May 5, 2026
stevensJourney
left a comment
Collaborator
There was a problem hiding this comment.
These changes look good to me
4d04b90 to
12c4def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we run a
BEGIN IMMEDIATEstatement to start transactions (both readonly and readwrite). Technically, we're not really supposed to useBEGIN IMMEDIATEfor readonly transactions since that statement is documented as taking a write lock, but for readonly connections in WAL mode it's still very convenient because there it uses the current state of the database as a snapshot. This has benefits over a regularBEGINbecause writes between the start of the readonly transaction and its first statement would not be seen (ensuring the entirereadTransactionblock forms a logical transaction).If we use readwrite connections with
pragma query_only = TRUEhowever, attempting to useBEGIN IMMEDIATEthrows and we shouldn't do it. So, this PR:pragma query_onlyworkaround.BEGIN IMMEDIATEfor connections using thepragma query_only = TRUEworkaround (which is the case for op-sqlite which can't open actual readonly connections).