fix(tauri): sanitize db path for Tauri event-name validation#956
Closed
msvargas wants to merge 1 commit into
Closed
fix(tauri): sanitize db path for Tauri event-name validation#956msvargas wants to merge 1 commit into
msvargas wants to merge 1 commit into
Conversation
|
Contributor
|
Thanks for your contribution! I'd like to close this in favor of generating integer keys for events, which should be safer and simpler overall (#957). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tauri validates event names against the pattern
[a-zA-Z0-9\-/:_]. The Tauri SDK uses the resolved database file path as the event-name key (e.g.table-updates:/Library/Application Support/com.barvaz.lacaja-ai/tenant.db). A typical macOS app data path contains dots (.dbextension, bundle ID components) and spaces (e.g.Application Support) — both characters are rejected by Tauri's event system, causing:This breaks any app that:
dbFilenamewith a.dbextension, ordbLocationAsyncto a directory that contains spaces or dots (which is the case for the standard macOS app-data directories).The result is that table-update and sync-status listeners are never registered, so the database appears frozen from JavaScript's perspective.
Fix
Add a
sanitize_event_namehelper inpackages/tauri/src/database.rsand a mirroredsanitizeEventKeyprivate method inpackages/tauri/guest-js/database.ts. Both replace every character outside[a-zA-Z0-9\-/:_]with_.Both sides use the same sanitization rule, so the Rust emitter and the JavaScript listener always produce identical event-name keys — the mapping is purely cosmetic and does not affect routing.
packages/tauri/src/database.rs— new helper + usage:packages/tauri/guest-js/database.ts— mirrored helper + usage:cc @simolus3 (author of the Tauri SDK, PR #902)