Tauri: Use numeric event identifiers for databases#957
Merged
Conversation
🦋 Changeset detectedLatest commit: 5910e31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
approved these changes
May 13, 2026
Co-authored-by: msvargas <msvargas97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @msvargas pointed out in #956, Tauri doesn't allow arbitrary characters in event names.
Currently, we encode the path of databases into event keys to allow JavaScript clients to listen to changed tables and the sync status. This was mostly me being lazy, using opaque identifiers for databases to generate events is probably a better approach than relying on paths (even when mangled). So, this has Rust assign an incrementing integer to created databases which is then used for events. We inform JavaScript about the id when a database is opened, allowing it to register event listeners.
This is covered by existing tests (
stream subscriptionsandwatch smoke test).