Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/smooth-lobsters-cross.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'tauri-plugin-powersync': patch
'@powersync/tauri-plugin': patch
---

Fix PowerSync using invalid tauri event names.
6 changes: 6 additions & 0 deletions packages/tauri/guest-js/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ export interface ExecuteBatchResult {
changes: number;
}

export interface CreatedDatabase {
handle: number;
event_key: number;
}

export type CommandResult =
| { CreatedDatabase: CreatedDatabase }
| { CreatedHandle: number }
| { ExecuteSqlResult: ExecuteSqlResult }
| { ExecuteBatchResult: ExecuteBatchResult }
Expand Down
23 changes: 12 additions & 11 deletions packages/tauri/guest-js/database.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
SyncStreamSubscription
} from '@powersync/common';
import { LateHandle, RustDatabaseAdapter } from './pool';
import { powersyncCommand } from './command';
import { CreatedDatabase, powersyncCommand } from './command';
import { listen, UnlistenFn } from '@tauri-apps/api/event';
import { join } from '@tauri-apps/api/path';

Expand Down Expand Up @@ -166,26 +166,27 @@ export class PowerSyncTauriDatabase extends AbstractPowerSyncDatabase {

async _initialize(): Promise<void> {
const path = await this.resolvePath();
this.tableUpdateListener = await listen<string[]>(`table-updates:${path}`, (event) => {
const result = await powersyncCommand({
OpenDatabase: {
name: path,
schema: this.schema.toJSON()
}
});

const { handle, event_key } = (result as any).CreatedDatabase as CreatedDatabase;
this.tableUpdateListener = await listen<string[]>(`table-updates:${event_key}`, (event) => {
const adapter = this.database;
if (adapter instanceof RustDatabaseAdapter) {
adapter.iterateListeners((l) =>
l.tablesUpdated?.({ tables: event.payload, rawUpdates: [], groupedUpdates: {} })
);
}
});
this.syncStatusListener = await listen<SyncStatusOptions>(`sync-status:${path}`, (event) => {
this.syncStatusListener = await listen<SyncStatusOptions>(`sync-status:${event_key}`, (event) => {
this.updateSyncStatusFromRust(event.payload);
});

const result = await powersyncCommand({
OpenDatabase: {
name: path,
schema: this.schema.toJSON()
}
});

this.handle.handle = (result as any).CreatedHandle as number;
this.handle.handle = handle;
if (this.database instanceof RustDatabaseAdapter) {
this.database.name = path;
}
Expand Down
10 changes: 9 additions & 1 deletion packages/tauri/src/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,10 @@ pub struct SubscribeToStream {

#[derive(Serialize)]
pub enum CommandResult {
CreatedDatabase {
handle: Handle,
event_key: i32,
},
CreatedHandle(Handle),
ExecuteSqlResult(ExecuteSqlResult),
ExecuteBatchResult {
Expand All @@ -273,7 +277,11 @@ pub(crate) async fn powersync<R: Runtime>(
SchemaOrCustom::from(open.schema.as_ref()),
)?;

CommandResult::CreatedHandle(powersync.handles.put(SharedWithJavaScript::Database(db)))
let event_key = db.event_key;
CommandResult::CreatedDatabase {
handle: powersync.handles.put(SharedWithJavaScript::Database(db)),
event_key,
}
}
Command::CloseHandle(handle) => {
powersync.handles.delete(handle)?;
Expand Down
12 changes: 9 additions & 3 deletions packages/tauri/src/database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,21 @@ use tokio_stream::StreamExt;

pub struct TauriDatabaseState {
pub database: PowerSyncDatabase,
pub event_key: i32,
forward_updates: JoinHandle<()>,
forward_sync_status: JoinHandle<()>,
}

impl TauriDatabaseState {
pub fn new<R: Runtime>(handle: AppHandle<R>, name: &str, source: PowerSyncDatabase) -> Self {
pub fn new<R: Runtime>(
handle: AppHandle<R>,
event_key: i32,
source: PowerSyncDatabase,
) -> Self {
let forward_updates = {
let handle = handle.clone();
let db = source.clone();
let event_key = format!("table-updates:{}", name);
let event_key = format!("table-updates:{}", event_key);

tokio::spawn(async move {
let mut stream = db.watch_all_updates();
Expand All @@ -32,7 +37,7 @@ impl TauriDatabaseState {
};
let forward_sync_status = {
let db = source.clone();
let event_key = format!("sync-status:{}", name);
let event_key = format!("sync-status:{}", event_key);

tokio::spawn(async move {
let mut stream = db.watch_status();
Expand All @@ -46,6 +51,7 @@ impl TauriDatabaseState {

Self {
database: source,
event_key,
forward_updates,
forward_sync_status,
}
Expand Down
6 changes: 5 additions & 1 deletion packages/tauri/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use powersync::{env::PowerSyncEnvironment, ConnectionPool, PowerSyncDatabase};
use rusqlite::Connection;
use std::collections::hash_map::Entry;
use std::marker::PhantomData;
use std::sync::atomic::{AtomicI32, Ordering};
use std::sync::{Arc, Weak};
use std::{collections::HashMap, sync::Mutex};
use tauri::{
Expand Down Expand Up @@ -35,6 +36,7 @@ impl<R: Runtime, T: Manager<R>> PowerSyncExt<R> for T {
pub struct PowerSync<R: Runtime> {
app: PhantomData<AppHandle<R>>,
databases: Mutex<HashMap<String, Weak<TauriDatabaseState>>>,
event_id_counter: AtomicI32,
pub(crate) handles: JavaScriptHandles,
}

Expand Down Expand Up @@ -72,7 +74,8 @@ impl<R: Runtime> PowerSync<R> {
let database = PowerSyncDatabase::new(env, schema);
database.async_tasks().spawn_with_tokio();

let db = Arc::new(TauriDatabaseState::new(app, name, database));
let event_id = self.event_id_counter.fetch_add(1, Ordering::SeqCst);
let db = Arc::new(TauriDatabaseState::new(app, event_id, database));
entry.insert_entry(Arc::downgrade(&db));

Ok(db)
Expand All @@ -95,6 +98,7 @@ pub fn init<R: Runtime>() -> TauriPlugin<R> {
app: PhantomData::<AppHandle<R>>,
databases: Default::default(),
handles: Default::default(),
event_id_counter: Default::default(),
};
app.manage(powersync);
Ok(())
Expand Down
Loading