Align crud uploads with Dart implementation#977
Merged
Conversation
🦋 Changeset detectedLatest commit: 1cffb2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
approved these changes
May 26, 2026
Contributor
Author
|
It looks like the Tauri integration tests are broken (timeouts without a message). They pass locally though, so I'll merge this and investigate those failures on another branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dart SDK invokes the CRUD upload method of the configured backend connector at least once per
connect()call, even if we can't connect to the streaming sync endpoint. We want the same behavior in the JS SDK, and this PR adds that.To make the implementation easier to reason about, this also aligns the implementation with the Dart SDK:
crudUploadLoopinconnect(), it takes a scoped abort signal now to abort along with the correspondingstreamingSync()call after a disconnect.Note that there are still some fishy things going on here, e.g. we break out of the
_uploadAllCrud()loop if there's an error and we're not connected. The Dart SDK does the same, and this PR is still an improvement, but we should probably spec out how we actually want the upload flow to behave before applying this to other SDKs.