Build demos as subprojects#236
Merged
Merged
Conversation
stevensJourney
approved these changes
Aug 5, 2025
stevensJourney
left a comment
Contributor
There was a problem hiding this comment.
I love the changes here.
I believe the Hello PowerSync demo was the original and somewhat basic demo we had before the Supabase todolist demo was fully functional. From my side, I don't have any concerns with removing this demo. We should update and remove and references to it in docs. E.g. https://docs.powersync.com/resources/demo-apps-example-projects#kotlin-multiplatform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds the three demo projects as subprojects, instead of making them individual roots that include the PowerSync SDK as a subbuild. More specifically, it:
:composeproject to Java 11: The updated KMP compose plugin generates Java 11 bytecode that can't be inlined into some of the methods we use in:compose. We still support Java 8 in all other projects.:android-supabase-todolistdemo into a subproject.hello-powersyncdemo. I don't know what purpose that demo would still have, it feels like a tiny subset of what we have in the KMP demo? I think it may be something left over from when we didn't have Desktop support in the main demo.:supabase-todolistdemos into subprojects.The main benefit of using subprojects is that we can open all demos by opening the main PowerSync SDK, which is considerably easier than managing them independently. Also, we now have all our dependencies in one place and don't need to upgrade versions in different places.
I have tested the KMP demo on iOS, Android and Desktop. I've also tested the standalone Android demo on Android.