Sync Streams: Allow array and object parameters#350
Merged
Conversation
stevensJourney
approved these changes
May 15, 2026
stevensJourney
left a comment
stevensJourney
left a comment
Contributor
There was a problem hiding this comment.
Happy with these changes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When subscribing to a Sync Stream with an array or object parameter, the mapping in
TypedRowattempting to map that value to Kotlin would fail because it only supports primitive values.Ideally, we should have used
Map<String, JsonParam>to represent parameters on stream. Doing that would be a breaking change now though, so we have to keep mapping values to Kotlin. So, this adds support for object and arrays toTypedRow.Closes #349.