Avoid forwarding writes on shadow tables to Room#358
Merged
Conversation
Chriztiaan
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Room integration, we use the update hook from the core extension to track writes made through PowerSync APIs. Calling
invalidationTracker.refreshin Room is only allowed for tables tracked by the Room schema of the database, passing another table makes that method throw.Before this PR, we filtered out internal Room and PowerSync tables and otherwise forwarded all changes. But when an fts5 table is used, we may also get notifications for internal shadow tables (like
fts_data,fts_docsizeand others). These also shouldn't be forwarded to Room. This PR adds a check to stop forwarding these.This also prepares the 1.13.0 release.