Fix bucket report comments and collection typing

Author: bean1352

modules/module-mongodb-storage/src/storage/implementation/MongoSyncBucketStorage.ts

@@ -581,8 +581,8 @@ export abstract class MongoSyncBucketStorage
    * when the whole bucket was read, otherwise estimated via {@link storage.estimateDistinctRows}); fragmentation is
    * then `operations / rows`.
    */
-  protected async estimateRowsFromOperationSample(
-    collection: mongo.Collection<any>,
+  protected async estimateRowsFromOperationSample<T extends mongo.Document>(
+    collection: mongo.Collection<T>,
     pipelinePrefix: mongo.Document[],
     operations: number,
     sampled: boolean

packages/service-core/src/routes/endpoints/admin.ts

@@ -271,9 +271,8 @@ export const validate = routeDefinition({
 /**
  * Per-bucket report of total operations vs total live rows in storage, for the active sync config.
  *
- * Answers the recurring "why is my Data Synced so high" question instance-wide
- * a high `operations / rows` ratio indicates fragmented buckets that a compact or
- * defragment can reclaim.
+ * Answers the recurring "why is my Data Synced so high" question. A high `operations / rows` ratio
+ * indicates fragmented buckets that a compact or defragment can reclaim.
  */
 export const bucketReport = routeDefinition({
   path: '/api/admin/v1/bucket-report',

packages/service-core/src/storage/SyncRulesBucketStorage.ts

@@ -173,8 +173,7 @@ export interface SyncRulesBucketStorage
    * Per-bucket report of total operations vs total live rows in storage.
    *
    * Intended for an on-demand admin/diagnostics view (e.g. answering "why is my Data Synced so high"),
-   * not as a live gauge. Operation and live-row counts are aggregated from storage; the exact source is
-   * backend-specific (MongoDB reads pre-aggregated bucket state, Postgres scans bucket data). May be
+   * not as a live gauge. How the counts are derived is backend-specific, and the report may be relatively
    * expensive on large instances.
    *
    * Optional: storage providers that don't implement it are reported as unsupported by the API.