Release tweaks (#690)

* Safer injection of ref.

* Remove defunct docker cache.

* Run dev releases in dockerhub environment.

* Ensure we only publish dev versions on docker-dev actions.

Author: rkistner

.github/workflows/docker-dev.yaml

@@ -13,6 +13,7 @@ jobs:
   release-docker-image:
     name: Build and Release powersync-service Docker Image
     runs-on: ubuntu-latest
+    environment: dockerhub
     steps:
       - name: Checkout
         uses: actions/checkout@v5
@@ -51,11 +52,31 @@ jobs:
           pnpm changeset status
           pnpm changeset version --snapshot dev
 
-        # This uses the service's package.json version for the Docker Image tag
-        # The changeset command above should change this to a dev package
-      - name: Get Service Version from package.json
+        # This uses the service's package.json version for the Docker Image tag.
+        # The changeset command above must change this to a dev package version.
+      - name: Get dev service version from package.json
         id: get_version
-        run: echo "SERVICE_VERSION=$(node -p "require('./service/package.json').version")" >> $GITHUB_OUTPUT
+        run: |
+          version="$(node -p "require('./service/package.json').version")"
+
+          node -e '
+            const semver = require("semver");
+            const version = process.argv[1];
+            const parsed = semver.parse(version);
+
+            if (!parsed) {
+              console.error("Service version " + version + " is not a valid semver version.");
+              process.exit(1);
+            }
+
+            const prerelease = parsed.prerelease.join(".");
+            if (!/^dev(?:[.-]|$)/.test(prerelease)) {
+              console.error("Service version " + version + " is not a dev snapshot version.");
+              process.exit(1);
+            }
+          ' "$version"
+
+          echo "SERVICE_VERSION=$version" >> "$GITHUB_OUTPUT"
 
       - name: Extract metadata for the image
         uses: docker/metadata-action@v5

.github/workflows/docker-next.yaml

@@ -24,13 +24,13 @@ jobs:
       - name: Validate release tag
         id: version
         run: |
-          if [ "${{ github.ref_type }}" != "tag" ]; then
+          if [ "$GITHUB_REF_TYPE" != "tag" ]; then
             echo "This workflow must be run against a git tag, e.g. gh workflow run docker-next --ref v1.21.0" >&2
             exit 1
           fi
 
           version="$(node -p "require('./service/package.json').version")"
-          tag="${{ github.ref_name }}"
+          tag="$GITHUB_REF_NAME"
 
           if [ "$tag" != "v$version" ]; then
             echo "Git tag $tag does not match service package version $version" >&2

.github/workflows/docker-stable.yaml

@@ -24,13 +24,13 @@ jobs:
       - name: Validate release tag
         id: version
         run: |
-          if [ "${{ github.ref_type }}" != "tag" ]; then
+          if [ "$GITHUB_REF_TYPE" != "tag" ]; then
             echo "This workflow must be run against a git tag, e.g. gh workflow run docker-stable --ref v1.21.0" >&2
             exit 1
           fi
 
           version="$(node -p "require('./service/package.json').version")"
-          tag="${{ github.ref_name }}"
+          tag="$GITHUB_REF_NAME"
 
           if [ "$tag" != "v$version" ]; then
             echo "Git tag $tag does not match service package version $version" >&2

.github/workflows/test.yml

@@ -60,7 +60,6 @@ jobs:
       - name: Test Build Docker Image
         uses: docker/build-push-action@v5
         with:
-          cache-from: type=registry,ref=stevenontong/${{vars.DOCKER_REGISTRY}}:cache
           context: .
           platforms: linux/amd64
           push: false