You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prevent command injection using github ref. The workflow is fairly safe since only approved users can run it, but it's better to do this properly.
Remove the stevenontong/${{vars.DOCKER_REGISTRY}}:cache cache in test builds - this cache did not work anyway, and I'm restricting the access of the default dockerhub user now.
Run dev images in the dockerhub environment, same as the next and stable releases.
For dev releases, add a check to ensure we don't accidentally publish a "stable" tag if there are no changesets.
This allows us to use separate users for dockerhub:
A read-only user for normal actions - only using an authenticated user here to avoid dockerhub rate limits.
A priviledged user in the dockerhub environment. This is only used when we need to push to dockerhub, and these workflows now require an additional approval step.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@stevensJourney I added a check to ensure the docker-dev workflow doesn't publish a stable version if there are no changesets. The "This branch had an error being deployed" is expected - that's this check in action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are minor tweaks to the release workflow:
stevenontong/${{vars.DOCKER_REGISTRY}}:cachecache in test builds - this cache did not work anyway, and I'm restricting the access of the default dockerhub user now.dockerhubenvironment, same as the next and stable releases.This allows us to use separate users for dockerhub:
dockerhubenvironment. This is only used when we need to push to dockerhub, and these workflows now require an additional approval step.