Require transactions

Author: simolus3

crates/core/src/schema/mod.rs

@@ -92,6 +92,11 @@ fn raw_table_migration(
     args: &[*mut sqlite::value],
 ) -> Result<(), PowerSyncError> {
     let db = context.db_handle();
+    if db.get_autocommit() {
+        return Err(PowerSyncError::argument_error(
+            "powersync_raw_table_migrate must be called within a transaction",
+        ));
+    }
     let context = unsafe { DatabaseState::from_context(&context) };
     let action = RawTableMigration::from_args(args)?;
 

dart/test/schema_test.dart

@@ -335,6 +335,14 @@ END''',
 
       setUp(() => db.execute('SELECT powersync_init();'));
 
+      test('requires a transaction', () {
+        expect(
+          () => db.execute(
+              'SELECT powersync_raw_table_migrate(?, ?)', ['create', syncName]),
+          throwsA(isA<SqliteException>()),
+        );
+      });
+
       group('create', () {
         void createUntypedItem(String id, Object? json) {
           db.execute(
@@ -354,8 +362,10 @@ END''',
           db.execute(
               'CREATE TABLE greetings (id TEXT PRIMARY KEY, hello TEXT) STRICT;');
 
+          db.execute('BEGIN');
           db.execute(
               'SELECT powersync_raw_table_migrate(?, ?)', ['create', syncName]);
+          db.execute('COMMIT');
           expect(db.select('select * from ps_untyped'), isEmpty);
           expect(db.select('select * from greetings'), [
             {'id': 'foo', 'hello': 'world'},
@@ -383,8 +393,10 @@ END''',
           db.execute(
               'CREATE TABLE greetings (id TEXT PRIMARY KEY, hello TEXT) STRICT;');
 
+          db.execute('BEGIN');
           db.execute(
               'SELECT powersync_raw_table_migrate(?, ?)', ['create', syncName]);
+          db.execute('COMMIT');
           expect(db.select('select * from ps_untyped'), isEmpty);
           expect(db.select('select * from greetings'), [
             {'id': 'foo', 'hello': 'world'},
@@ -405,14 +417,16 @@ END''',
             'INSERT INTO greetings (id, hello, local) VALUES (?, ?, uuid())',
             ['id_1', 'second'],
           )
+          ..execute('BEGIN')
           ..execute('SELECT powersync_raw_table_migrate(?, ?)', [
             'drop',
             json.encode({
               'name': syncName,
               'table_name': 'greetings',
               'synced_columns': ['hello']
             })
-          ]);
+          ])
+          ..execute('COMMIT');
 
         expect(db.select('select * from ps_untyped'), [
           {'type': 'synced_table', 'id': 'id_0', 'data': '{"hello":"first"}'},
@@ -425,8 +439,8 @@ END''',
             json.encode({'name': syncName, 'table_name': 'greetings'});
 
         db.execute('SELECT powersync_replace_schema(?)', [
-          json.encode(
-              singleRawTableSchema({'name': syncName, 'table_name': 'greetings'})),
+          json.encode(singleRawTableSchema(
+              {'name': syncName, 'table_name': 'greetings'})),
         ]);
         db.execute(
             'CREATE TABLE greetings (id TEXT PRIMARY KEY, hello TEXT) STRICT;');
@@ -439,12 +453,21 @@ SELECT
 ''', [tableJson]);
 
         db
-          ..execute('INSERT INTO ps_untyped (type, id, data) VALUES (?, ?, ?)',
-              [syncName, 'id_1', json.encode({'hello': 'world'})])
-          ..execute('INSERT INTO ps_untyped (type, id, data) VALUES (?, ?, ?)',
-              [syncName, 'id_2', json.encode({'hello': 'again'})]);
+          ..execute(
+              'INSERT INTO ps_untyped (type, id, data) VALUES (?, ?, ?)', [
+            syncName,
+            'id_1',
+            json.encode({'hello': 'world'})
+          ])
+          ..execute(
+              'INSERT INTO ps_untyped (type, id, data) VALUES (?, ?, ?)', [
+            syncName,
+            'id_2',
+            json.encode({'hello': 'again'})
+          ]);
 
         // create migration: ps_untyped -> raw table; triggers must not fire
+        db.execute('BEGIN');
         db.execute(
             'SELECT powersync_raw_table_migrate(?, ?)', ['create', syncName]);
         expect(db.select('SELECT * FROM ps_crud'), isEmpty);
@@ -454,6 +477,7 @@ SELECT
           'drop',
           json.encode({'name': syncName, 'table_name': 'greetings'}),
         ]);
+        db.execute('COMMIT');
         expect(db.select('SELECT * FROM ps_crud'), isEmpty);
       });
     });