AI comments

Author: stevensJourney

crates/core/src/migrations.rs

@@ -488,6 +488,9 @@ DROP TABLE ps_sync_state_old;
         // After copying, the `$local` row is deleted: version 14 tracks this state exclusively in
         // ps_kv, so ps_buckets only contains real sync buckets. The down migration recreates the
         // row from ps_kv when needed.
+        //
+        // DROP COLUMN requires SQLite 3.35+; the extension already refuses to load below
+        // MIN_SQLITE_VERSION_NUMBER (3.44), so this is safe in the up path.
         let up = "\
 DELETE FROM ps_kv
  WHERE key IN (

crates/core/src/sync/storage_adapter.rs

@@ -528,7 +528,8 @@ WHERE bucket = ?1",
     /// `next_checkpoint_request_id`.
     ///
     /// Returns the target op value from before this call. When `target_op` is `None`, this only
-    /// reads the current value.
+    /// reads the current value. A `target_op` of zero clears the stored target, removing the apply
+    /// gate entirely; any other value overwrites it.
     ///
     /// Negative values are rejected when parsing the `powersync_control` payload, before this is
     /// called.

crates/core/src/view_admin.rs

@@ -163,7 +163,9 @@ fn trigger_resync(db: *mut sqlite::sqlite3, state: &DatabaseState) -> Result<(),
         }
     }
 
-    db.exec_safe("UPDATE ps_buckets SET last_applied_op = 0 WHERE name != '$local'")
+    // Since migration v14, ps_buckets only contains real sync buckets: the synthetic `$local`
+    // bucket has moved to ps_kv, so no filter is needed here.
+    db.exec_safe("UPDATE ps_buckets SET last_applied_op = 0")
         .into_db_result(db)?;
     Ok(Default::default())
 }

dart/test/sync_test.dart

@@ -468,6 +468,20 @@ void _syncTests<T>({
     invokeControlRaw('seed_checkpoint_request_id', 5);
     expect(lastRequestedCheckpointRequestId(), 5);
     expect(nextCheckpointRequestId(), 6);
+
+    // A NULL seed is stored as 0, restarting the counter. Forwarding a raw NULL service response
+    // while a counter exists resets it - SDKs must reconcile before seeding.
+    invokeControlRaw('seed_checkpoint_request_id', null);
+    expect(lastRequestedCheckpointRequestId(), 0);
+    expect(nextCheckpointRequestId(), 1);
+  });
+
+  syncTest('accepts text checkpoint request ids when seeding', (_) {
+    invokeControlRaw('start', null);
+    invokeControlRaw('seed_checkpoint_request_id', '41');
+
+    expect(lastRequestedCheckpointRequestId(), 41);
+    expect(nextCheckpointRequestId(), 42);
   });
 
   syncTest('requires checkpoint request state before allocating checkpoint ids',