AI feedback

Author: simolus3

Sources/PowerSyncGRDB/Connections/AllWritesObserver.swift

@@ -2,10 +2,10 @@ import GRDB
 
 class AllWritesObserver: TransactionObserver {
     private(set) var committedTables: Set<String> = []
-    private var uncomittedTables: Set<String> = []
+    private var uncommittedTables: Set<String> = []
 
     var databaseEventObservationStrategy: DatabaseEventObservationStrategy {
-        var strategy = DatabaseEventObservationStrategy.default
+        var strategy: DatabaseEventObservationStrategy = DatabaseEventObservationStrategy.default
         // Don't filter on database event kind, so that we are
         // notified of changes performed through the SQLite C API:
         strategy.requiresDatabaseEventKind = false
@@ -18,15 +18,15 @@ class AllWritesObserver: TransactionObserver {
     }
 
     func databaseDidChange(with event: DatabaseEvent) {
-        uncomittedTables.insert(event.tableName)
+        uncommittedTables.insert(event.tableName)
     }
 
     func databaseDidCommit(_ db: GRDB.Database) {
-        committedTables.formUnion(uncomittedTables)
-        uncomittedTables.removeAll()
+        committedTables.formUnion(uncommittedTables)
+        uncommittedTables.removeAll()
     }
 
     func databaseDidRollback(_ db: GRDB.Database) {
-        uncomittedTables.removeAll()
+        uncommittedTables.removeAll()
     }
 }

Sources/PowerSyncGRDB/Connections/GRDBConnectionLease.swift

@@ -49,6 +49,7 @@ extension PowerSync.PowerSyncDataType: DatabaseValueConvertible {
     }
 
     public static func fromDatabaseValue(_ dbValue: GRDB.DatabaseValue) -> PowerSync.PowerSyncDataType? {
+        // Unused, we only need databaseValue to pass PowerSyncDataType as StatementParameters
         nil
     }
 }

Sources/PowerSyncGRDB/Connections/RowIterator.swift

@@ -47,43 +47,43 @@ struct RowSqlCursor: PowerSync.SqlCursor {
     }
 
     public func getBooleanOptional(index: Int) -> Bool? {
-        return row.self[index]
+        return row[index]
     }
 
     public func getDouble(index: Int) throws(PowerSync.SqlCursorError) -> Double {
         try checkNotNull(index: index)
-        return row.self[index]
+        return row[index]
     }
 
     public func getDoubleOptional(index: Int) -> Double? {
-        return row.self[index]
+        return row[index]
     }
 
     public func getInt(index: Int) throws(PowerSync.SqlCursorError) -> Int {
         try checkNotNull(index: index)
-        return row.self[index]
+        return row[index]
     }
 
     public func getIntOptional(index: Int) -> Int? {
-        return row.self[index]
+        return row[index]
     }
 
     public func getInt64(index: Int) throws(PowerSync.SqlCursorError) -> Int64 {
         try self.checkNotNull(index: index)
-        return row.self[index]
+        return row[index]
     }
 
     public func getInt64Optional(index: Int) -> Int64? {
-        return row.self[index]
+        return row[index]
     }
 
     public func getString(index: Int) throws(PowerSync.SqlCursorError) -> String {
         try self.checkNotNull(index: index)
-        return row.self[index]
+        return row[index]
     }
 
     public func getStringOptional(index: Int) -> String? {
-        return row.self[index]
+        return row[index]
     }
 
     public var columnCount: Int {

Tests/PowerSyncGRDBTests/BasicTest.swift

@@ -452,6 +452,34 @@ final class GRDBTests: XCTestCase {
 
         XCTAssert(warningIndex! >= 0)
     }
+
+    func testBindValues() async throws {
+        try await database.readLock { lease in
+            try lease.get(
+                sql: "SELECT ?, ?, ?, ?, ?, ?, typeof(?), typeof(?)",
+                parameters: [
+                    nil,
+                    false,
+                    Int32(32),
+                    Int64(64),
+                    3.14,
+                    "hello",
+                    Data(),
+                    Data([1, 2, 3])
+                ],
+                mapper: { cursor in
+                    XCTAssertEqual(cursor.getStringOptional(index: 0), nil)
+                    XCTAssertEqual(try cursor.getBoolean(index: 1), false)
+                    XCTAssertEqual(try cursor.getInt(index: 2), 32)
+                    XCTAssertEqual(try cursor.getInt(index: 3), 64)
+                    XCTAssertEqual(try cursor.getDouble(index: 4), 3.14)
+                    XCTAssertEqual(try cursor.getString(index: 5), "hello")
+                    XCTAssertEqual(try cursor.getString(index: 6), "blob")
+                    XCTAssertEqual(try cursor.getString(index: 7), "blob")
+                }
+            )
+        }
+    }
 }
 
 final class TestLogWriterAdapter: LogWriterProtocol,