Implement CRUD transactions in Swift instead of Kotlin#127
Merged
Conversation
Contributor
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
I'm generally happy with these changes. The typed crud entries are a very nice addition. I left some minor comments for some items that caught my eye.
stevensJourney
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods returning items from
ps_crud(getCrudBatch(),getCrudTransactions()andgetNextCrudTransaction()) don't do anything special: They read some items fromps_crudviagetAll, marking a batch as completed removes the crud items and updates a target write checkpoint in the$localbucket. They don't need any integration with database internals.So, implementing these methods in Swift is an easy first step towards eventually removing the Kotlin framework. This also allows us to provide typed values for
opDataandpreviousValues, previously they both had to be a[String: String?]map due to interop limitations.