Allow render for nested model#368
Open
bpardee wants to merge 2 commits into
Open
Conversation
|
@bpardee: are you using this in prod / tested this more perhaps? Might want to pull this |
Contributor
Author
|
Yes, I use it for Nested Models and haven't had any issues. |
Collaborator
|
Hi, there are conflicts here, could you remove the dist files ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #361 and #363 and allows render to maintain values for the Object and NestedModel editor. The Object changes are completely untested and the NestedModel hasn't been tested but seems to work okay for me. Therefore I'm not recommending that you actually pull this but I think it is a reasonable starting point if someone with more time than I have right now wants to formalize this change.