Fix bus voltage and angle stability#3906
Open
samirromdhani wants to merge 3 commits into
Open
Conversation
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
samirromdhani
force-pushed
the
fix/2509-stability-of-bus-voltage-and-angle
branch
from
ce1b74d to
1ffa0b5
Compare
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
|
rolnico
reviewed
May 7, 2026
| } | ||
|
|
||
| private static boolean hasDefinedVoltageOrAngle(NodeTerminal t) { | ||
| return !Double.isNaN(t.getV()) || !Double.isNaN(t.getAngle()); |
Member
There was a problem hiding this comment.
@olperr1 should we check that both values are not NaN or having only one is enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #2509
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: