Add a name to the permanent limit#3909
Open
NathanDissoubray wants to merge 15 commits into
Open
Conversation
…nstant value Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
NathanDissoubray
force-pushed
the
3887-permanent_limit_name
branch
from
c615aba to
50a5882
Compare
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
olperr1
requested changes
May 15, 2026
Member
olperr1
left a comment
olperr1
left a comment
There was a problem hiding this comment.
I haven't finished yet, but here are some first comments.
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
olperr1
requested changes
May 19, 2026
Comment on lines
+385
to
+389
| <xs:attribute name="permanentLimit" use="optional" type="xs:double"/> | ||
| </xs:complexType> | ||
| <xs:complexType name="permanentLimit"> | ||
| <xs:attribute name="name" use="optional" type="xs:string"/> | ||
| <xs:attribute name="value" use="required" type="xs:double"/> |
Member
There was a problem hiding this comment.
To limit the size of the IIDM files, we could:
- keep the permanent limit value as an attribute of
LoadingLimit. - introduce another optional attribute for the permanent limit name
- and export it only when it is not the default name. But this will require Skip writing default attribute values in IIDM serialization #3826
Contributor
Author
There was a problem hiding this comment.
Indeed, since this PR might be ready before #3826 I'll write it always and mention it in that PR. It might be good to get a consensus to ensure that this default value should not be written
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
olperr1
requested changes
May 27, 2026
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com> Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Closes #3887
What kind of change does this PR introduce?
Add a name that can be set in a permanent limit (with a default value)
What is the current behavior?
There is no name for a permanent limit.
What is the new behavior (if this is a feature change)?
Now there is a name.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
In
iidm-api:LimitViolationUtils.PERMANENT_LIMIT_NAMEhas been removed. You can instead useLoadingLimits.DEFAULT_PERMANENT_LIMIT_NAMEIf you are using
iidm-impl, the following changes might impact you:PermanentLimitInfonow takes an additional name String, which corresponds to the name of the permanent limit.notifyPermanentLimitUpdatenow takes two new String arguments,oldNameandnewName.CurrentLimitsImpl,ApparentPowerLimitsImplandActivePowerLimitsImplconstructors now take an additionalpermanentLimitNameString argument.Other information: