various

Author: JaskRendix

docs/add_widgets.py

@@ -118,7 +118,7 @@ def func(name):
 elif EXAMPLE == "CLOCK":
     menu = make_menu(pygame_menu.themes.THEME_DARK, "Clock")
 
-    clock = menu.add.clock(font_size=25, font_name=pygame_menu.font.FONT_DIGITAL)
+    menu.add.clock(font_size=25, font_name=pygame_menu.font.FONT_DIGITAL)
 
 elif EXAMPLE == "COLORINPUT":
     menu = make_menu(pygame_menu.themes.THEME_DARK, "Color Entry")
@@ -145,13 +145,13 @@ def func(name):
 elif EXAMPLE == "DROPSELECT":
     menu = make_menu(pygame_menu.themes.THEME_DEFAULT, "Drop Select")
 
-    selector_epic = menu.add.dropselect(
+    menu.add.dropselect(
         title="Is pygame-menu epic?",
         items=[("Yes", 0), ("Absolutely Yes", 1)],
         font_size=16,
         selection_option_font_size=20,
     )
-    selector_sum = menu.add.dropselect(
+    menu.add.dropselect(
         title="What is the value of π?",
         items=[
             ("3 (Engineer)", 0),
@@ -164,7 +164,7 @@ def func(name):
         selection_option_padding=(0, 5),
         selection_option_font_size=20,
     )
-    selector_country = menu.add.dropselect(
+    menu.add.dropselect(
         title="Pick a country",
         items=[
             ("Argentina", "ar"),
@@ -196,7 +196,7 @@ def func(name):
     )
     menu.add.vertical_margin(75)
 
-    selector = menu.add.dropselect_multiple(
+    menu.add.dropselect_multiple(
         title="Pick 3 colors",
         items=[
             ("Black", (0, 0, 0)),
@@ -382,7 +382,7 @@ def open_link(*args) -> None:
         onchange=change_background_color,  # User changes value with left/right keys
     )
     selector.add_self_to_kwargs()  # Callbacks will receive widget as parameter
-    selector2 = menu.add.selector(
+    menu.add.selector(
         title="New color:", items=items, style=pygame_menu.widgets.SELECTOR_STYLE_FANCY
     )
 

pygame_menu/_decorator.py

@@ -1152,6 +1152,7 @@ def _update_pos_list(
         try:
             decoid_exists = self._coord_cache[decoid] is not None
         except KeyError:
+            # No cached coordinates for this decoid; proceed as if unseen
             pass
         if (
             decoid_exists

pygame_menu/widgets/widget/colorinput.py

@@ -360,7 +360,7 @@ def value_changed(self) -> bool:
             default = "#" + default
         return self.get_value(as_string=True) != default
 
-    def get_value(self, as_string: bool = False) -> str | Tuple3IntType:
+    def get_value(self, as_string: bool = False) -> str | float | int | Tuple3IntType:
         """
         Return the color value as a tuple or red blue and green channels.
 
@@ -371,7 +371,6 @@ def get_value(self, as_string: bool = False) -> str | Tuple3IntType:
         :param as_string: If ``True`` returns the widget value as plain text
         :return: Color tuple as (R, G, B) or color string
         """
-        assert isinstance(as_string, bool)
         if as_string:
             return self._input_string
 

pygame_menu/widgets/widget/dropselect.py

@@ -1089,7 +1089,7 @@ def _up(self) -> None:
         self._sound.play_key_add()
         return None
 
-    def set_value(self, item: str | int) -> None:
+    def set_value(self, item: str | int, process_index: bool = False) -> None:
         """
         Set the current value of the widget, selecting the item that matches the
         text if ``item`` is a string, or the index if ``item`` is an integer.
@@ -1104,10 +1104,9 @@ def set_value(self, item: str | int) -> None:
 
             This method does not trigger any event (change).
 
-        :param item: Item to select, can be a string or an integer
+        :param item: The item to select, either a string or an integer index.
+        :param process_index: Ignored in this class; used by subclasses.
         """
-        assert isinstance(item, (str, int)), "item must be a string or an integer"
-
         if isinstance(item, str):
             found = False
             for i in self._items:
@@ -1117,13 +1116,17 @@ def set_value(self, item: str | int) -> None:
                     break
             if not found:
                 raise ValueError(f'no value "{item}" found in drop select')
+
         elif isinstance(item, int):
             assert -1 <= item < len(self._items), (
                 "item index must be greater than zero and lower than the number "
                 "of items on the drop select"
             )
             self._index = item
 
+        # Base class ignores process_index
+        # (DropSelectMultiple overrides and uses it)
+
         # Update options background selection
         for b_ind_x in range(len(self._option_buttons)):
             btn = self._option_buttons[b_ind_x]

pygame_menu/widgets/widget/dropselect_multiple.py

@@ -490,8 +490,6 @@ def set_value(self, item: str | int, process_index: bool = False) -> None:
         :param item: Item to select, can be a string or an integer
         :param process_index: Adds/Removes the index from the selected indices list
         """
-        assert isinstance(item, (str, int)), "item must be a string or an integer"
-
         if isinstance(item, str):
             found = False
             for i in self._items:

pygame_menu/widgets/widget/table.py

@@ -432,6 +432,7 @@ def add_row(
                 try:
                     cell.get_menu().remove_widget(cell)
                 except ValueError:
+                    # Removal can fail if the cell is no longer registered in the menu
                     pass
 
             # Check the cell frame is None
@@ -866,6 +867,7 @@ def update_cell_style(
         try:
             cell.update_font({"color": font_color, "name": font})
         except AssertionError:
+            # Font update may fail if parameters are invalid; ignore and keep previous font
             pass
 
         try:

pygame_menu/widgets/widget/textinput.py

@@ -29,6 +29,7 @@
     NumberType,
     Tuple2IntType,
     Tuple2NumberType,
+    Tuple3IntType,
 )
 from pygame_menu.locals import FINGERDOWN, FINGERUP, INPUT_FLOAT, INPUT_INT, INPUT_TEXT
 from pygame_menu.utils import (
@@ -463,26 +464,32 @@ def clear(self) -> None:
         self._delete()
         self.change()
 
-    def get_value(self) -> str:
+    def get_value(self, as_string: bool = False) -> str | float | int | Tuple3IntType:
         """
         Return the value of the text.
 
-        :return: Text inside the widget
+        :param as_string: If True, return the raw input string
+        :return: Text inside the widget, or converted number
         """
-        value = ""
+        if as_string:
+            return self._input_string
+
         if self._input_type == INPUT_TEXT:
-            value = self._input_string  # Without filters
-        elif self._input_type == INPUT_FLOAT:
+            return self._input_string
+
+        if self._input_type == INPUT_FLOAT:
             try:
-                value = float(self._input_string)
+                return float(self._input_string)
             except ValueError:
-                value = 0
-        elif self._input_type == INPUT_INT:
+                return 0
+
+        if self._input_type == INPUT_INT:
             try:
-                value = int(float(self._input_string))
+                return int(float(self._input_string))
             except ValueError:
-                value = 0
-        return value
+                return 0
+
+        return self._input_string
 
     def scale(self, *args, **kwargs) -> TextInput:
         raise WidgetTransformationNotImplemented()