Fix for issue #171.#340
Open
hakonhagland wants to merge 1 commit intopplu:masterfrom
Open
Conversation
Due to a bug (?) in the URI module, a query string without an "=" sign is not considered a query string. Unfortunately, this causes $qparam to become empty (i.e. to delete the "versions" query parameter) at line pplu#218 in lib/Paws/Net/RestXmlCaller.pm. Which will later turn the GET request to the REST API into something other than a versions request, and the returned response will not make sense.
Contributor
|
Relevant URI issue: libwww-perl/URI#34 |
Contributor
|
this should have been fixed by 0de24da which is already released, please re-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the call
ListObjectVersions()at line #378 inauto-lib/Paws/S3.pm. This will generate an object of typePaws::S3::ListObjectsVersion, see fileauto-lib/Paws/S3/ListObjectVersions.pm. This object has a field_api_uriwhich is initialized to/{Bucket}?versions. Note that the query string of the previous URI does not contain an "=" sign.Due to a bug (?) in the URI module, a query string without an "=" sign is not considered a query string.
Unfortunately, this causes
$qparamto become empty (i.e. to accidentally delete theversionsquery parameter) at line #218 inlib/Paws/Net/RestXmlCaller.pm. Which will later turn the GET requestto the REST API into something other than a
versionsrequest, and the returned response will not make sense either.See Using the REST API for more information on expected format of GET request.