Skip to content

Commit 4ccfa34

Browse files
committed
Support ssl/tls protocol for Credis
1 parent 61e1bff commit 4ccfa34

2 files changed

Lines changed: 20 additions & 20 deletions

File tree

lib/Redis.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ public static function parseDsn($dsn)
223223
$parts = parse_url($dsn);
224224

225225
// Check the URI scheme
226-
$validSchemes = array('redis', 'rediss', 'tcp');
226+
$validSchemes = array('redis', 'tcp', 'rediss', 'tls', 'ssl');
227227
if (isset($parts['scheme']) && ! in_array($parts['scheme'], $validSchemes)) {
228228
throw new InvalidArgumentException("Invalid DSN. Supported schemes are " . implode(', ', $validSchemes));
229229
}
@@ -267,7 +267,7 @@ public static function parseDsn($dsn)
267267
}
268268

269269
return array(
270-
$parts['host'],
270+
$parts['scheme'] . '://' . $parts['host'],
271271
$port,
272272
$database,
273273
$user,

test/Resque/Tests/RedisTest.php

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -41,126 +41,126 @@ public function validDsnStringProvider()
4141
return array(
4242
// Input , Expected output
4343
array('', array(
44-
'localhost',
44+
'redis://localhost',
4545
6379,
4646
false,
4747
false, false,
4848
array(),
4949
)),
5050
array('localhost', array(
51-
'localhost',
51+
'tcp://localhost',
5252
6379,
5353
false,
5454
false, false,
5555
array(),
5656
)),
5757
array('localhost:1234', array(
58-
'localhost',
58+
'tcp://localhost',
5959
1234,
6060
false,
6161
false, false,
6262
array(),
6363
)),
6464
array('localhost:1234/2', array(
65-
'localhost',
65+
'tcp://localhost',
6666
1234,
6767
2,
6868
false, false,
6969
array(),
7070
)),
7171
array('redis://foobar', array(
72-
'foobar',
72+
'redis://foobar',
7373
6379,
7474
false,
7575
false, false,
7676
array(),
7777
)),
7878
array('redis://foobar/', array(
79-
'foobar',
79+
'redis://foobar',
8080
6379,
8181
false,
8282
false, false,
8383
array(),
8484
)),
8585
array('redis://foobar:1234', array(
86-
'foobar',
86+
'redis://foobar',
8787
1234,
8888
false,
8989
false, false,
9090
array(),
9191
)),
9292
array('redis://foobar:1234/15', array(
93-
'foobar',
93+
'redis://foobar',
9494
1234,
9595
15,
9696
false, false,
9797
array(),
9898
)),
9999
array('redis://foobar:1234/0', array(
100-
'foobar',
100+
'redis://foobar',
101101
1234,
102102
0,
103103
false, false,
104104
array(),
105105
)),
106106
array('redis://user@foobar:1234', array(
107-
'foobar',
107+
'redis://foobar',
108108
1234,
109109
false,
110110
'user', false,
111111
array(),
112112
)),
113113
array('redis://user@foobar:1234/15', array(
114-
'foobar',
114+
'redis://foobar',
115115
1234,
116116
15,
117117
'user', false,
118118
array(),
119119
)),
120120
array('redis://user:pass@foobar:1234', array(
121-
'foobar',
121+
'redis://foobar',
122122
1234,
123123
false,
124124
'user', 'pass',
125125
array(),
126126
)),
127127
array('redis://user:pass@foobar:1234?x=y&a=b', array(
128-
'foobar',
128+
'redis://foobar',
129129
1234,
130130
false,
131131
'user', 'pass',
132132
array('x' => 'y', 'a' => 'b'),
133133
)),
134134
array('redis://:pass@foobar:1234?x=y&a=b', array(
135-
'foobar',
135+
'redis://foobar',
136136
1234,
137137
false,
138138
false, 'pass',
139139
array('x' => 'y', 'a' => 'b'),
140140
)),
141141
array('redis://user@foobar:1234?x=y&a=b', array(
142-
'foobar',
142+
'redis://foobar',
143143
1234,
144144
false,
145145
'user', false,
146146
array('x' => 'y', 'a' => 'b'),
147147
)),
148148
array('redis://foobar:1234?x=y&a=b', array(
149-
'foobar',
149+
'redis://foobar',
150150
1234,
151151
false,
152152
false, false,
153153
array('x' => 'y', 'a' => 'b'),
154154
)),
155155
array('redis://user@foobar:1234/12?x=y&a=b', array(
156-
'foobar',
156+
'redis://foobar',
157157
1234,
158158
12,
159159
'user', false,
160160
array('x' => 'y', 'a' => 'b'),
161161
)),
162162
array('tcp://user@foobar:1234/12?x=y&a=b', array(
163-
'foobar',
163+
'tcp://foobar',
164164
1234,
165165
12,
166166
'user', false,

0 commit comments

Comments
 (0)