Skip to content

Fix bug when 2 signals in a pair are not perfectly aligned for wavelet coherence #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patricefortin merged 1 commit into from
Jul 11, 2025
Merged

Fix bug when 2 signals in a pair are not perfectly aligned for wavelet coherence #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hypyp/wavelet/base_wavelet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,12 @@ def _get_cache_key_pair(self, pair: PairSignals, subject_idx: int, obj_id: str,
if subject_idx == 0:
subject_label = pair.label_s1
ch_name = pair.label_ch1
# include signal length in key because it might have been croped to align y1 and y2
n = len(pair.y1)
elif subject_idx == 1:
subject_label = pair.label_s2
ch_name = pair.label_ch2
n = len(pair.y2)
else:
raise RuntimeError(f'subject_idx must be 0 or 1')

Expand All @@ -437,7 +440,7 @@ def _get_cache_key_pair(self, pair: PairSignals, subject_idx: int, obj_id: str,
raise RuntimeError(f'must have task to have unique identifiers in caching')

time_range_str = f'{pair.x[0]}-{pair.x[-1]}'
key = f'[{subject_label}][{ch_name}][{pair.label_task}][{pair.epoch_idx}][{pair.x[0]}-{pair.x[-1]}][{time_range_str}][{obj_id}]'
key = f'[{subject_label}][{ch_name}][{pair.label_task}][{pair.epoch_idx}][{n}][{pair.x[0]}-{pair.x[-1]}][{time_range_str}][{obj_id}]'
if cache_suffix != '':
key += f'_{cache_suffix}'

Expand Down