qspibus: three low-cost cleanups consistent with CircuitPython conventions

Co-authored-by: ppsx <7107135+ppsx@users.noreply.github.com>

Author: Copilot

locale/circuitpython.pot

@@ -978,6 +978,7 @@ msgstr ""
 
 #: ports/espressif/common-hal/busio/SPI.c
 #: ports/espressif/common-hal/canio/CAN.c
+#: ports/espressif/common-hal/qspibus/QSPIBus.c
 msgid "ESP-IDF memory allocation failed"
 msgstr ""
 
@@ -1065,10 +1066,6 @@ msgstr ""
 msgid "Failed to create continuous channels: not found"
 msgstr ""
 
-#: ports/espressif/common-hal/qspibus/QSPIBus.c
-msgid "Failed to create semaphore"
-msgstr ""
-
 #: ports/espressif/common-hal/audioio/AudioOut.c
 msgid "Failed to enable continuous"
 msgstr ""

ports/espressif/common-hal/qspibus/QSPIBus.c

@@ -287,7 +287,7 @@ void common_hal_qspibus_qspibus_construct(
 
     self->transfer_done_sem = xSemaphoreCreateCounting(QSPI_DMA_BUFFER_COUNT, 0);
     if (self->transfer_done_sem == NULL) {
-        mp_raise_msg(&mp_type_MemoryError, MP_ERROR_TEXT("Failed to create semaphore"));
+        mp_raise_msg(&mp_type_MemoryError, MP_ERROR_TEXT("ESP-IDF memory allocation failed"));
     }
 
     if (!qspibus_allocate_dma_buffers(self)) {
@@ -428,15 +428,6 @@ bool common_hal_qspibus_qspibus_deinited(qspibus_qspibus_obj_t *self) {
     return !self->bus_initialized;
 }
 
-void common_hal_qspibus_qspibus_send_command(
-    qspibus_qspibus_obj_t *self,
-    uint8_t command,
-    const uint8_t *data,
-    size_t len) {
-    qspibus_send_command_bytes(self, command, data, len);
-}
-
-
 void common_hal_qspibus_qspibus_write_command(
     qspibus_qspibus_obj_t *self,
     uint8_t command) {

shared-bindings/qspibus/QSPIBus.c

@@ -106,7 +106,7 @@ static mp_obj_t qspibus_qspibus_obj_reset(mp_obj_t self_in) {
 }
 static MP_DEFINE_CONST_FUN_OBJ_1(qspibus_qspibus_reset_obj, qspibus_qspibus_obj_reset);
 
-//|     def send(self, command: int, data: ReadableBuffer = b"") -> None:
+//|     def send(self, command: int, data: Optional[ReadableBuffer] = None) -> None:
 //|         """Send command with optional payload bytes.
 //|
 //|         This mirrors FourWire-style convenience API:
@@ -119,7 +119,7 @@ static mp_obj_t qspibus_qspibus_send(size_t n_args, const mp_obj_t *pos_args, mp
     enum { ARG_command, ARG_data };
     static const mp_arg_t allowed_args[] = {
         { MP_QSTR_command, MP_ARG_INT | MP_ARG_REQUIRED },
-        { MP_QSTR_data, MP_ARG_OBJ, {.u_obj = mp_const_empty_bytes} },
+        { MP_QSTR_data, MP_ARG_OBJ, {.u_obj = mp_const_none} },
     };
 
     mp_arg_val_t args[MP_ARRAY_SIZE(allowed_args)];

shared-bindings/qspibus/QSPIBus.h

@@ -31,11 +31,6 @@ void common_hal_qspibus_qspibus_construct(
 void common_hal_qspibus_qspibus_deinit(qspibus_qspibus_obj_t *self);
 bool common_hal_qspibus_qspibus_deinited(qspibus_qspibus_obj_t *self);
 
-void common_hal_qspibus_qspibus_send_command(
-    qspibus_qspibus_obj_t *self,
-    uint8_t command,
-    const uint8_t *data,
-    size_t len);
 void common_hal_qspibus_qspibus_write_command(
     qspibus_qspibus_obj_t *self,
     uint8_t command);