hundle null score in replay stats

Author: notbakaneko

app/Libraries/Transformers/Scope.php

@@ -121,7 +121,10 @@ protected function fireTransformer($transformer, $data): array
             }
         }
 
-        [$transformedData, $includedData] = parent::fireTransformer($transformer, $data);
+        // mergeIncludes called by fireTransformers requires arrays, so just skip calling everything if data is null.
+        if ($data !== null) {
+            [$transformedData, $includedData] = parent::fireTransformer($transformer, $data);
+        }
 
         if (empty($transformedData) && empty($includedData)) {
             return [null, []];

app/Transformers/ScoreTransformer.php

@@ -63,8 +63,12 @@ public function __construct(?bool $legacyFormat = null)
         $this->legacyFormat = $legacyFormat ?? (is_api_request() && api_version() < 20220705);
     }
 
-    public function transform(LegacyMatch\Score|MultiplayerScoreLink|SoloScore $score)
+    public function transform(LegacyMatch\Score|MultiplayerScoreLink|SoloScore|null $score)
     {
+        if ($score === null) {
+            return null;
+        }
+
         if ($this->legacyFormat) {
             return $this->transformLegacy($score);
         }

resources/js/interfaces/score-replay-stats-json.ts

@@ -4,7 +4,7 @@
 import ScoreJson, { ScoreJsonForUser } from './score-json';
 
 interface ScoreReplayStatsJsonAvailableIncludes {
-  score: ScoreJson;
+  score: ScoreJson|null;
 }
 
 interface ScoreReplayStatsJsonDefaultAttributes {
@@ -16,4 +16,4 @@ type ScoreReplayStatsJson = ScoreReplayStatsJsonDefaultAttributes & Partial<Scor
 
 export default ScoreReplayStatsJson;
 
-export type ScoreReplayStatsJsonForUser = ScoreReplayStatsJson & { score: ScoreJsonForUser };
+export type ScoreReplayStatsJsonForUser = ScoreReplayStatsJson & { score: ScoreJsonForUser|null };

resources/js/profile-page/score-replay-stats-entry.tsx

@@ -25,6 +25,10 @@ export default function ScoreReplayStatsEntry(props: Props) {
   const user = props.user;
   const stats = props.stats;
   const score = stats.score;
+  if (score == null) {
+    return null;
+  }
+
   const scoreRank = rank(score);
   const { beatmap, beatmapset } = score;