Clean up and update quick/ranked play rankings#12920
Draft
LiquidPL wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
Drafting this for if we'll even need to bring quick play rankings back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notably this changes the tab on the ranking page from
quick playtomatchmakingwhile still being under the same translation key which should be fine cuz crowdin should catch that, while also changing the routes a bit.the ranked play tab is showing no dropdown here since i only had one pool in the DB (which i believe is the current behaviour anyway). also sorry for not having any test data in here.updated the screenshots