Show user mention suggestion box#12965
Open
nanaya wants to merge 3 commits into
Open
Conversation
notbakaneko
requested changes
May 26, 2026
Collaborator
There was a problem hiding this comment.
(still checking)
Flashing the old results doesn't seem right:
https://github.com/user-attachments/assets/baf9c104-c974-48a8-bcf6-8c8f3f239d52
...where's the embed
| @observable visible = false; | ||
|
|
||
| @observable private readonly cache: Partial<Record<string, UserSearchEntry[]>> = {}; | ||
| private readonly debouncedFetchSuggestions = debounce(() => this.fetchSuggestions()); |
Collaborator
There was a problem hiding this comment.
this ends up sending a query every key press?
| } | ||
|
|
||
| @observer | ||
| export default class MentionCompletionBox extends React.Component<Props> { |
Collaborator
There was a problem hiding this comment.
need makeObservable(this) for @action to work
- confusing when coming back from autocompleted name (@ -> autocomplete -> move cursor back) - even worse when going back from there (different type of flashing) - there's also leftover of the search spinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this can be split further 🫥
One of the class names should be
...Controllerinstead of...Statebut it's rather long already.The result itself probably needs improvement from #12633. Mainly boosting the active users part.