Skip to content

Skip existence checks for user replay stats#12966

Draft
notbakaneko wants to merge 1 commit into
ppy:masterfrom
notbakaneko:skip-score-existence
Draft

Skip existence checks for user replay stats#12966
notbakaneko wants to merge 1 commit into
ppy:masterfrom
notbakaneko:skip-score-existence

Conversation

@notbakaneko
Copy link
Copy Markdown
Collaborator

@notbakaneko notbakaneko commented May 14, 2026

#12945 and #12946 take 2, with extra null handling

duplicates fireTransformer to insert our extra null handling

@notbakaneko notbakaneko marked this pull request as draft May 14, 2026 23:32
@notbakaneko
Copy link
Copy Markdown
Collaborator Author

notbakaneko commented May 14, 2026

Causes other problem handling nulls
shouldn't have assumed transform(null) = null

@notbakaneko notbakaneko force-pushed the skip-score-existence branch from fb0023d to ea8227b Compare May 15, 2026 00:51
@notbakaneko notbakaneko marked this pull request as ready for review May 15, 2026 00:51
@nanaya
Copy link
Copy Markdown
Collaborator

nanaya commented May 15, 2026

is the problem just the counting or fetching the rows as well?

@notbakaneko
Copy link
Copy Markdown
Collaborator Author

notbakaneko commented May 15, 2026

it's both; the exists against large tables has large overheads in production.

Also, it doesn't make sense if the count doesn't match, although, if it's not rendered.... 🤔

@nanaya
Copy link
Copy Markdown
Collaborator

nanaya commented May 15, 2026

the queries I've been seeing are all on the count though...? (also the matchmaking thing change here doesn't match the pr title?)

the replay count specifically can probably be fixed by doing ->limit(maxResults)->pluck('score_id')->count() instead

@notbakaneko notbakaneko marked this pull request as draft May 15, 2026 10:42
@notbakaneko
Copy link
Copy Markdown
Collaborator Author

we'll hold off on this for now

@notbakaneko notbakaneko force-pushed the skip-score-existence branch from ea8227b to a7545b0 Compare May 18, 2026 09:40
@notbakaneko notbakaneko force-pushed the skip-score-existence branch from a7545b0 to f93aba3 Compare May 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants