Skip existence checks for user replay stats#12966
Draft
notbakaneko wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
|
fb0023d to
ea8227b
Compare
Collaborator
|
is the problem just the counting or fetching the rows as well? |
Collaborator
Author
|
it's both; the Also, it doesn't make sense if the count doesn't match, although, if it's not rendered.... 🤔 |
Collaborator
|
the queries I've been seeing are all on the count though...? (also the matchmaking thing change here doesn't match the pr title?) the replay count specifically can probably be fixed by doing |
Collaborator
Author
|
we'll hold off on this for now |
ea8227b to
a7545b0
Compare
a7545b0 to
f93aba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12945 and #12946 take 2, with extra
nullhandlingduplicates
fireTransformerto insert our extranullhandling