Follow-up fixes for client-side slots implementation#37868
Merged
Conversation
Would cause the participant count limit to not update on the multiplayer match screen.
The kicked user is unsubscribed from receiving room state updates before their slot is vacated, which then would lead this code to attempt to look the local, kicked user via the unvacated slot and thus fail because `client.Room.Users` does *not* contain the user anymore. This is a bit of a dicey change but I think it's less dicey than to try to wiggle ordering server-side.
bdach
changed the title
peppy
approved these changes
May 24, 2026
github-project-automation
Bot
moved this from Pending Review
to Done
in osu! team task tracker
This was referenced May 26, 2026
This was referenced Jun 3, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fell out of full-stack testing with ppy/osu-server-spectator#513.
Fix missing property copy in multiplayer client
Would cause the participant count limit to not update on the multiplayer match screen.
Fix hard crash when user is kicked from a room with slots active
The kicked user is unsubscribed from receiving room state updates before their slot is vacated, which then would lead this code to attempt to look the local, kicked user via the unvacated slot and thus fail because
client.Room.Usersdoes not contain the user anymore.This is a bit of a dicey change but I think it's less dicey than to try to wiggle ordering server-side.