Skip to content

Commit d417b6b

Browse files
mkannwischerhanno-becker
authored andcommitted
HOL-Light: Switch to mld_ namespace
Previously, the HOL-Light assembly kernels used the default PQCP namespace. This namespace is both overly verbose and prefixed with the ML-DSA parameter set, which in the context of parameter-set independent assembly is confusing. This commit switches the namespace used in the HOL-Light assembly to `mld_`. Ports pq-code-package/mlkem-native#1739. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
1 parent b11d111 commit d417b6b

33 files changed

Lines changed: 133 additions & 129 deletions

proofs/hol_light/aarch64/mldsa/intt_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
.text
3232
.balign 4
3333
#ifdef __APPLE__
34-
.global _PQCP_MLDSA_NATIVE_MLDSA44_intt_aarch64_asm
35-
_PQCP_MLDSA_NATIVE_MLDSA44_intt_aarch64_asm:
34+
.global _mld_intt_aarch64_asm
35+
_mld_intt_aarch64_asm:
3636
#else
37-
.global PQCP_MLDSA_NATIVE_MLDSA44_intt_aarch64_asm
38-
PQCP_MLDSA_NATIVE_MLDSA44_intt_aarch64_asm:
37+
.global mld_intt_aarch64_asm
38+
mld_intt_aarch64_asm:
3939
#endif
4040

4141
.cfi_startproc

proofs/hol_light/aarch64/mldsa/keccak_f1600_x1_scalar_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@
4040
.text
4141
.balign 4
4242
#ifdef __APPLE__
43-
.global _PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_scalar_aarch64_asm
44-
_PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_scalar_aarch64_asm:
43+
.global _mld_keccak_f1600_x1_scalar_aarch64_asm
44+
_mld_keccak_f1600_x1_scalar_aarch64_asm:
4545
#else
46-
.global PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_scalar_aarch64_asm
47-
PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_scalar_aarch64_asm:
46+
.global mld_keccak_f1600_x1_scalar_aarch64_asm
47+
mld_keccak_f1600_x1_scalar_aarch64_asm:
4848
#endif
4949

5050
.cfi_startproc

proofs/hol_light/aarch64/mldsa/keccak_f1600_x1_v84a_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@
5656
.text
5757
.balign 4
5858
#ifdef __APPLE__
59-
.global _PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_v84a_aarch64_asm
60-
_PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_v84a_aarch64_asm:
59+
.global _mld_keccak_f1600_x1_v84a_aarch64_asm
60+
_mld_keccak_f1600_x1_v84a_aarch64_asm:
6161
#else
62-
.global PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_v84a_aarch64_asm
63-
PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x1_v84a_aarch64_asm:
62+
.global mld_keccak_f1600_x1_v84a_aarch64_asm
63+
mld_keccak_f1600_x1_v84a_aarch64_asm:
6464
#endif
6565

6666
.cfi_startproc

proofs/hol_light/aarch64/mldsa/keccak_f1600_x2_v84a_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@
5656
.text
5757
.balign 4
5858
#ifdef __APPLE__
59-
.global _PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x2_v84a_aarch64_asm
60-
_PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x2_v84a_aarch64_asm:
59+
.global _mld_keccak_f1600_x2_v84a_aarch64_asm
60+
_mld_keccak_f1600_x2_v84a_aarch64_asm:
6161
#else
62-
.global PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x2_v84a_aarch64_asm
63-
PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x2_v84a_aarch64_asm:
62+
.global mld_keccak_f1600_x2_v84a_aarch64_asm
63+
mld_keccak_f1600_x2_v84a_aarch64_asm:
6464
#endif
6565

6666
.cfi_startproc

proofs/hol_light/aarch64/mldsa/keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@
4040
.text
4141
.balign 4
4242
#ifdef __APPLE__
43-
.global _PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm
44-
_PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm:
43+
.global _mld_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm
44+
_mld_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm:
4545
#else
46-
.global PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm
47-
PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm:
46+
.global mld_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm
47+
mld_keccak_f1600_x4_v8a_scalar_hybrid_aarch64_asm:
4848
#endif
4949

5050
.cfi_startproc

proofs/hol_light/aarch64/mldsa/keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@
4141
.text
4242
.balign 4
4343
#ifdef __APPLE__
44-
.global _PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm
45-
_PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm:
44+
.global _mld_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm
45+
_mld_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm:
4646
#else
47-
.global PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm
48-
PQCP_MLDSA_NATIVE_MLDSA44_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm:
47+
.global mld_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm
48+
mld_keccak_f1600_x4_v8a_v84a_scalar_hybrid_aarch64_asm:
4949
#endif
5050

5151
.cfi_startproc

proofs/hol_light/aarch64/mldsa/mld_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
.text
1212
.balign 4
1313
#ifdef __APPLE__
14-
.global _PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm
15-
_PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm:
14+
.global _mld_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm
15+
_mld_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm:
1616
#else
17-
.global PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm
18-
PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm:
17+
.global mld_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm
18+
mld_polyvecl_pointwise_acc_montgomery_l4_aarch64_asm:
1919
#endif
2020

2121
.cfi_startproc

proofs/hol_light/aarch64/mldsa/mld_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
.text
1212
.balign 4
1313
#ifdef __APPLE__
14-
.global _PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm
15-
_PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm:
14+
.global _mld_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm
15+
_mld_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm:
1616
#else
17-
.global PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm
18-
PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm:
17+
.global mld_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm
18+
mld_polyvecl_pointwise_acc_montgomery_l5_aarch64_asm:
1919
#endif
2020

2121
.cfi_startproc

proofs/hol_light/aarch64/mldsa/mld_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
.text
1212
.balign 4
1313
#ifdef __APPLE__
14-
.global _PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm
15-
_PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm:
14+
.global _mld_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm
15+
_mld_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm:
1616
#else
17-
.global PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm
18-
PQCP_MLDSA_NATIVE_MLDSA44_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm:
17+
.global mld_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm
18+
mld_polyvecl_pointwise_acc_montgomery_l7_aarch64_asm:
1919
#endif
2020

2121
.cfi_startproc

proofs/hol_light/aarch64/mldsa/ntt_aarch64_asm.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
.text
3232
.balign 4
3333
#ifdef __APPLE__
34-
.global _PQCP_MLDSA_NATIVE_MLDSA44_ntt_aarch64_asm
35-
_PQCP_MLDSA_NATIVE_MLDSA44_ntt_aarch64_asm:
34+
.global _mld_ntt_aarch64_asm
35+
_mld_ntt_aarch64_asm:
3636
#else
37-
.global PQCP_MLDSA_NATIVE_MLDSA44_ntt_aarch64_asm
38-
PQCP_MLDSA_NATIVE_MLDSA44_ntt_aarch64_asm:
37+
.global mld_ntt_aarch64_asm
38+
mld_ntt_aarch64_asm:
3939
#endif
4040

4141
.cfi_startproc

0 commit comments

Comments
 (0)