native: Unify asm backend symbol naming#1058
Open
mkannwischer wants to merge 3 commits intomainfrom
Open
Conversation
50f1dbe to
77cdf80
Compare
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)⏭️ 16 proof(s) skipped (see
Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)⏭️ 16 proof(s) skipped (see
Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)⏭️ 16 proof(s) skipped (see
Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (186 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (186 proofs)
|
de75385 to
21599aa
Compare
21599aa to
a84b37f
Compare
Every aarch64 asm symbol now ends in `_aarch64_asm`; every x86_64 avx2 symbol now ends in `_avx2_asm`. Port of pq-code-package/mlkem-native#1663 (commit 2/4). Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Port of pq-code-package/mlkem-native#1663 (commit 3/4). Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Drop proofs/hol_light/x86_64/README.md, which duplicated the proofs listing and reproducing instructions from the top-level README and was already drifting (missing pointwise and pointwise_acc_l4/l5/l7). Move its unique content (Primer with example spec, Platform Compatibility) into the top-level README, matching mlkem-native's structure. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
a84b37f to
bf2d64e
Compare
jakemas
pushed a commit
that referenced
this pull request
Apr 27, 2026
…_utils dep
- Rename {.S,.ml} to poly_use_hint_{32,88}_aarch64_asm for PR #1058 consolidation
- Move mldsa_use_hint_{32,88}_spec to common/mldsa_specs.ml for x86 sharing
- Remove pointless IVAL_SMALL/VAL_IWORD_NUM aliases; use actual names
- Add aarch64_utils.ml to CI needs for both proofs
- Align comment style between _32 and _88 spec definitions
- Update Makefile, dump_bytecode, subroutine_signatures, README
Signed-off-by: Jake Massimo <jakemas@amazon.com>
jakemas
added a commit
that referenced
this pull request
Apr 27, 2026
…_utils dep
- Rename {.S,.ml} to poly_use_hint_{32,88}_aarch64_asm for PR #1058 consolidation
- Move mldsa_use_hint_{32,88}_spec to common/mldsa_specs.ml for x86 sharing
- Remove pointless IVAL_SMALL/VAL_IWORD_NUM aliases; use actual names
- Add aarch64_utils.ml to CI needs for both proofs
- Align comment style between _32 and _88 spec definitions
- Update Makefile, dump_bytecode, subroutine_signatures, README
Signed-off-by: Jake Massimo <jakemas@amazon.com>
jakemas
added a commit
that referenced
this pull request
Apr 27, 2026
…_utils dep
- Rename {.S,.ml} to poly_use_hint_{32,88}_aarch64_asm for PR #1058 consolidation
- Move mldsa_use_hint_{32,88}_spec to common/mldsa_specs.ml for x86 sharing
- Remove pointless IVAL_SMALL/VAL_IWORD_NUM aliases; use actual names
- Add aarch64_utils.ml to CI needs for both proofs
- Align comment style between _32 and _88 spec definitions
- Update Makefile, dump_bytecode, subroutine_signatures, README
Signed-off-by: Jake Massimo <jakemas@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.