CI: Authenticate GitHub API requests in more test-running jobs#1279
Merged
Conversation
Jobs running make quickcheck or scripts/tests download ACVP and Wycheproof test vectors from the GitHub API. Several jobs ran these downloads unauthenticated and intermittently failed with HTTP 403 rate-limit errors on the shared runner IPs. This commit adds the authentication token to more jobs. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
CBMC Results (ML-DSA-44)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (206 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (206 proofs)
|
hanno-becker
approved these changes
Jul 11, 2026
Contributor
|
I’ve been developing all day and watching CI. Its failure rate feels higher than 70% per run on these!! |
jakemas
reviewed
Jul 11, 2026
jakemas
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. TY for addressing so quickly.
jakemas
approved these changes
Jul 11, 2026
Contributor
Author
unfortuantely, there seems to be another problem... some requests get a |
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Contributor
Author
I have added some retry logic and now it should hopefully be stable. @jakemas, if you see more random failures, can you please send them to me (or open an issue)? We need to get CI stable so that the merge queue can work effectively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs running make quickcheck or scripts/tests download ACVP and Wycheproof test vectors from the GitHub API. Several jobs ran these downloads unauthenticated and intermittently failed with HTTP 403 rate-limit errors on the shared runner IPs.
This commit adds the authentication token to more jobs.