Scripts: Drop dead assignments and stray f-string prefixes

Enable ruff F841 (unused variable) and F541 (empty f-string)
and address flagged code locations.

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>

Author: mkannwischer

proofs/cbmc/lib/summarize.py

@@ -137,7 +137,6 @@ def export_result_json(output_path, run_file):
 
     failures, runtimes = [], []
     for name, status, duration_str in proof_table[1:]:  # skip header
-        is_timeout = duration_str == "TIMEOUT"
         is_success = status == "Success"
 
         if not is_success:

ruff.toml

@@ -18,6 +18,4 @@ ignore = [
     "E713", # `not in` rather than `not X in Y`
     "E731", # lambda assignment
     "E741", # ambiguous variable name
-    "F541", # f-string without any placeholders
-    "F841", # unused variable
 ]

scripts/autogen

@@ -2592,7 +2592,6 @@ def get_syscaps():
 
 def check_macro_typos():
     files = get_all_files()
-    configs = get_config_options()
     syscaps = get_syscaps()
 
     macros = set(map(lambda t: t[1], get_defines(all=True)))
@@ -2713,7 +2712,6 @@ def check_asm_loop_labels_for_file(filename):
     content = read_file(filename)
 
     # Find function symbol name
-    func_pattern = r"MLK_ASM_FN_SYMBOL\((.*)\)"
     res = _RE_FUNC_SYMBOL.search(content)
     if res is None:
         raise Exception(f"Could not find function symbol in assembly file {filename}")
@@ -2894,7 +2892,7 @@ def update_via_simpasm(
             # Add syntax option for x86_64
             if arch == "x86_64" and x86_64_syntax != "att":
                 cmd += ["--syntax", x86_64_syntax]
-            r = subprocess.run(
+            subprocess.run(
                 cmd,
                 stdout=subprocess.DEVNULL,
                 stderr=subprocess.PIPE,
@@ -3290,7 +3288,7 @@ def synchronize_backends(
         )
 
         update_via_copy(
-            f"dev/x86_64/meta.h",
+            "dev/x86_64/meta.h",
             "mlkem/src/native/x86_64/meta.h",
             transform=lambda c: adjust_header_guard_for_filename(
                 c, "mlkem/src/native/x86_64/meta.h"
@@ -3404,7 +3402,7 @@ def adjust_header_guard_for_filename(content, header_file):
         yield f"#define {guard_name}"
 
     def gen_footer():
-        yield f"#endif"
+        yield "#endif"
         yield ""
 
     guard = list(gen_guard())
@@ -3714,7 +3712,7 @@ def gen_c_citations_for(filename, bibliography):
             raise Exception(
                 f"Could not find bibliography entry {cite_id} referenced in {filename}"
             )
-        references.append(f" *")
+        references.append(" *")
         references.append(f" * - [{cite_id}]")
         prefix = " *   "
         # Wrap long lines at 80 chars
@@ -3799,11 +3797,11 @@ def gen_bib_file(bibliography):
         content.append(f"### `{cite_id}`")
         content.append("")
         content.append(f"* {entry.name}")
-        content.append(f"* Author(s):")
+        content.append("* Author(s):")
         for author in entry.authors:
             content.append(f"  - {author}")
         content.append(f"* URL: {entry.url}")
-        content.append(f"* Referenced from:")
+        content.append("* Referenced from:")
         # Usages are pairs of (filename, line_count)
         # Ignore line_count for now, as it would require `autogen` after
         # a change to source files.

scripts/simpasm

@@ -274,7 +274,7 @@ def simplify(logger, args, asm_input, asm_output=None):
         autogen_header = [
             "",
             "/*",
-            f" * WARNING: This file is auto-derived from the mlkem-native source file",
+            " * WARNING: This file is auto-derived from the mlkem-native source file",
             f" *   {asm_input} using scripts/simpasm. Do not modify it directly.",
             " */",
             "",
@@ -352,7 +352,7 @@ def simplify(logger, args, asm_input, asm_output=None):
             + elf_stack_section
         )
 
-        logger.debug(f"Assembling simplified assembly ...")
+        logger.debug("Assembling simplified assembly ...")
         logger.debug(new_asm)
         logger.debug(f"Command: {' '.join(cmd)}")
         run_cmd(cmd, input=new_asm)

scripts/tests

@@ -1317,7 +1317,7 @@ def cli():
     )
 
     # wycheproof arguments
-    wycheproof_parser = cmd_subparsers.add_parser(
+    cmd_subparsers.add_parser(
         "wycheproof", help="Run Wycheproof client", parents=[common_parser]
     )
 
@@ -1377,7 +1377,7 @@ def cli():
         action="store_true",
         default=False,
     )
-    size_parser = cmd_subparsers.add_parser(
+    cmd_subparsers.add_parser(
         "size",
         help="Run the code size measurement for all object file",
         parents=[common_parser],
@@ -1493,12 +1493,12 @@ def cli():
     )
 
     # kat arguments
-    kat_parser = cmd_subparsers.add_parser(
+    cmd_subparsers.add_parser(
         "kat", help="Run the kat tests for all parameter sets", parents=[common_parser]
     )
 
     # unit arguments
-    unit_parser = cmd_subparsers.add_parser(
+    cmd_subparsers.add_parser(
         "unit",
         help="Run the unit tests for all parameter sets",
         parents=[common_parser],
@@ -1524,14 +1524,14 @@ def cli():
     )
 
     # alloc arguments
-    alloc_parser = cmd_subparsers.add_parser(
+    cmd_subparsers.add_parser(
         "alloc",
         help="Run the alloc tests for all parameter sets",
         parents=[common_parser],
     )
 
     # rng_fail arguments
-    rng_fail_parser = cmd_subparsers.add_parser(
+    cmd_subparsers.add_parser(
         "rng_fail",
         help="Run the RNG failure tests for all parameter sets",
         parents=[common_parser],