Hoist noise generation in encaps into separate helper#1630
Draft
hanno-becker wants to merge 2 commits intomainfrom
Draft
Hoist noise generation in encaps into separate helper#1630hanno-becker wants to merge 2 commits intomainfrom
hanno-becker wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Contributor
|
Suerly the title of the PR is wrong? This is about "enc" not "keygen"?? |
Contributor
|
Where is the Makefile for the new helper function? Forgotten "git add" ? |
hanno-becker
changed the title
Contributor
|
This does not look ready, @hanno-becker? Marking as draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to @rod-chapman's #1621, but this time primarily for uniformity.