Skip to content

Test; Add sp align for performance; no proof updates #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manastasova wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Test; Add sp align for performance; no proof updates #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dev/fips202/x86_64/src/keccak_f1600_x4_avx2.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ MLK_ASM_FN_SYMBOL(keccak_f1600_x4_avx2)
// 0x1e0(%rsp) A23 (state0[23), state1[23], state2[23], state3[23]] Input (%rdi) offsets: 0xB8, 0x180, 0x248, 0x310
// %ymm2 A24 (state0[24), state1[24], state2[24], state3[24]] Input (%rdi) offsets: 0xC0, 0x188, 0x250, 0x318

movq %rsp, %r11
andq $0xffffffffffffffe0, %rsp
subq $0x300, %rsp

// Load 32 bytes from each of the 4 states (A(0-3))
Expand Down Expand Up @@ -615,7 +617,7 @@ MLK_ASM_FN_SYMBOL(keccak_f1600_x4_avx2)
vmovhpd %xmm3, 0x188(%rdi)
vmovq %xmm15, 0x250(%rdi)
vmovhpd %xmm15, 0x318(%rdi)
addq $0x300, %rsp
movq %r11, %rsp
ret

/* simpasm: footer-start */
Expand Down
5 changes: 3 additions & 2 deletions mlkem/src/fips202/native/x86_64/src/keccak_f1600_x4_avx2.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
MLK_ASM_FN_SYMBOL(keccak_f1600_x4_avx2)

.cfi_startproc
movq %rsp, %r11
andq $-0x20, %rsp
subq $0x300, %rsp # imm = 0x300
.cfi_adjust_cfa_offset 0x300
vmovdqu (%rdi), %ymm0
Expand Down Expand Up @@ -441,8 +443,7 @@ LLkeccak_f1600_x4_avx2:
vmovhpd %xmm3, 0x188(%rdi)
vmovq %xmm15, 0x250(%rdi)
vmovhpd %xmm15, 0x318(%rdi)
addq $0x300, %rsp # imm = 0x300
.cfi_adjust_cfa_offset -0x300
movq %r11, %rsp
retq
.cfi_endproc

Expand Down
5 changes: 3 additions & 2 deletions proofs/hol_light/x86_64/mlkem/keccak_f1600_x4_avx2.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ PQCP_MLKEM_NATIVE_MLKEM768_keccak_f1600_x4_avx2:

.cfi_startproc
endbr64
movq %rsp, %r11
andq $-0x20, %rsp
subq $0x300, %rsp # imm = 0x300
.cfi_adjust_cfa_offset 0x300
vmovdqu (%rdi), %ymm0
Expand Down Expand Up @@ -444,7 +446,6 @@ LLkeccak_f1600_x4_avx2:
vmovhpd %xmm3, 0x188(%rdi)
vmovq %xmm15, 0x250(%rdi)
vmovhpd %xmm15, 0x318(%rdi)
addq $0x300, %rsp # imm = 0x300
.cfi_adjust_cfa_offset -0x300
movq %r11, %rsp
retq
.cfi_endproc
Loading