Skip to content

Wycheproof: Fix incorrect assertion for invalid encaps/decaps tests #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkannwischer merged 1 commit into from
Apr 18, 2026
Merged

Wycheproof: Fix incorrect assertion for invalid encaps/decaps tests #1636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 38 additions & 28 deletions test/wycheproof/wycheproof_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,17 @@ def run_keygen_seed_test(data_file):
for tc in tg["tests"]:
info(f" tcId={tc['tcId']} ... ", end="")
out = run_binary([binary, "keygen_seed", f"seed={tc['seed']}"])
if "_error" in out or "decode_error" in out:
assert (
tc["result"] == "invalid"
), f"binary error on non-invalid tcId={tc['tcId']}"
elif tc["result"] in ("valid", "acceptable"):
if tc["result"] == "valid":
assert (
out["ek"].upper() == tc["ek"].upper()
), f"ek mismatch tcId={tc['tcId']}"
assert (
out["dk"].upper() == tc["dk"].upper()
), f"dk mismatch tcId={tc['tcId']}"
else:
assert (
False
), f"Unexpected result '{tc['result']}' for tcId={tc['tcId']}"
info("ok")
count += 1
info(f" {count} keygen_seed tests passed")
Expand All @@ -132,21 +132,22 @@ def run_encaps_test(data_file):
for tc in tg["tests"]:
info(f" tcId={tc['tcId']} ... ", end="")
out = run_binary([binary, "encaps", f"ek={tc['ek']}", f"m={tc['m']}"])
if "_error" in out or "decode_error" in out:
if tc["result"] == "invalid":
# _error: non-zero exit code; decode_error: explicit validation failure
assert (
tc["result"] == "invalid"
), f"binary error on non-invalid tcId={tc['tcId']}"
elif tc["result"] in ("valid", "acceptable"):
"_error" in out or "decode_error" in out
Comment thread
mkannwischer marked this conversation as resolved.
), f"binary success on invalid tcId={tc['tcId']}"
elif tc["result"] == "valid":
assert (
out["c"].upper() == tc["c"].upper()
), f"c mismatch tcId={tc['tcId']}"
assert (
out["K"].upper() == tc["K"].upper()
), f"K mismatch tcId={tc['tcId']}"
elif tc["result"] == "invalid":
else:
assert (
out["K"].upper() != tc["K"].upper()
), f"K should not match for invalid tcId={tc['tcId']}"
False
), f"Unsupported test result '{tc['result']}' for tcId={tc['tcId']}"
info("ok")
count += 1
info(f" {count} encaps tests passed")
Expand All @@ -165,9 +166,17 @@ def run_semi_expanded_decaps_test(data_file):
for tc in tg["tests"]:
info(f" tcId={tc['tcId']} ... ", end="")
out = run_binary([binary, "decaps", f"dk={tc['dk']}", f"c={tc['c']}"])
# For errors (wrong length dk/c, or runtime failure), just check it didn't crash unexpectedly
if "_error" not in out and "decode_error" not in out:
if tc["result"] == "invalid":
# _error: non-zero exit code; decode_error: explicit validation failure
assert (
"_error" in out or "decode_error" in out
), f"binary success on invalid tcId={tc['tcId']}"
elif tc["result"] == "valid":
assert "K" in out, f"missing K in output tcId={tc['tcId']}"
else:
assert (
False
), f"Unsupported test result '{tc['result']}' for tcId={tc['tcId']}"
info("ok")
count += 1
info(f" {count} semi_expanded_decaps tests passed")
Expand All @@ -187,33 +196,34 @@ def run_combined_test(data_file):
info(f" tcId={tc['tcId']} ... ", end="")
# Generate keypair from seed
keygen_out = run_binary([binary, "keygen_seed", f"seed={tc['seed']}"])
if "_error" in keygen_out or "decode_error" in keygen_out:
if "decode_error" in keygen_out:
assert (
tc["result"] == "invalid"
), f"keygen error on non-invalid tcId={tc['tcId']}"
), f"keygen decode error on valid tcId={tc['tcId']}"
info("ok")
count += 1
continue
# Check ek matches if present
if "ek" in tc and tc["result"] in ("valid", "acceptable"):
assert (
keygen_out["ek"].upper() == tc["ek"].upper()
), f"ek mismatch tcId={tc['tcId']}"
# Keygen succeeded — check ek
assert "ek" in tc, f"missing ek in test vector tcId={tc['tcId']}"
assert (
keygen_out["ek"].upper() == tc["ek"].upper()
), f"ek mismatch tcId={tc['tcId']}"
# Decapsulate
dk = keygen_out["dk"]
decaps_out = run_binary([binary, "decaps", f"dk={dk}", f"c={tc['c']}"])
if "_error" in decaps_out or "decode_error" in decaps_out:
if tc["result"] == "invalid":
# _error: non-zero exit code; decode_error: explicit validation failure
assert (
tc["result"] == "invalid"
), f"decaps error on non-invalid tcId={tc['tcId']}"
elif tc["result"] in ("valid", "acceptable"):
"_error" in decaps_out or "decode_error" in decaps_out
), f"binary success on invalid tcId={tc['tcId']}"
elif tc["result"] == "valid":
assert (
decaps_out["K"].upper() == tc["K"].upper()
), f"K mismatch tcId={tc['tcId']}"
elif tc["result"] == "invalid":
else:
assert (
decaps_out["K"].upper() != tc["K"].upper()
), f"K should not match for invalid tcId={tc['tcId']}"
False
), f"Unsupported test result '{tc['result']}' for tcId={tc['tcId']}"
info("ok")
count += 1
info(f" {count} combined tests passed")
Expand Down
Loading