Remove --no-array-field-sensitivity for all proofs#1654
Merged
hanno-becker merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
1. Remove --no-array-field-sensitivty from all per-function Makefiles
2. Update Makefile.common to:
a. Reject --slice-formula if specified in a per-function Makefile, since
it is already added by default in Makefile.common now.
b. Reject --no-array-field-sensitivity if specified in a per-function Makefile
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Contributor
Author
|
Proof time data before and after this PR, for K=2,3,4 macOS,-j8, CPU user time in minutes:seconds Grv4 (EC2 r8g.metal-24xlarge)/Ubuntu, -j96 |
Contributor
CBMC Results (ML-KEM-1024)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (191 proofs)
|
Contributor
CBMC Results (ML-KEM-512)Full Results (191 proofs)
|
Co-authored-by: Hanno Becker <beckphan@amazon.co.uk> Signed-off-by: Roderick Chapman <rodchap@amazon.com>
hanno-becker
approved these changes
Apr 20, 2026
mkannwischer
added a commit
to pq-code-package/mldsa-native
that referenced
this pull request
Apr 20, 2026
Ports pq-code-package/mlkem-native#1654 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
added a commit
to pq-code-package/mldsa-native
that referenced
this pull request
Apr 20, 2026
Ports pq-code-package/mlkem-native#1654 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove --no-array-field-sensitivity from all per-function Makefiles
Update Makefile.common to:
a. Reject --slice-formula if specified in a per-function Makefile, since it is already added by default in Makefile.common now.
b. Reject --no-array-field-sensitivity if specified in a per-function Makefile